<p>Harald Welte <strong>merged</strong> this change.</p><p><a href="https://gerrit.osmocom.org/13977">View Change</a></p><div style="white-space:pre-wrap">Approvals:
  Harald Welte: Looks good to me, approved
  Jenkins Builder: Verified

</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">sms_queue_test: assert return value of osmo_use_count_get_put()<br><br>Change-Id: I9381e88435ccd856ec619135ca9999c15c25d436<br>Fixes: CID#198416<br>---<br>M tests/sms_queue/sms_queue_test.c<br>1 file changed, 4 insertions(+), 3 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/tests/sms_queue/sms_queue_test.c b/tests/sms_queue/sms_queue_test.c</span><br><span>index 495e078..25fc312 100644</span><br><span>--- a/tests/sms_queue/sms_queue_test.c</span><br><span>+++ b/tests/sms_queue/sms_queue_test.c</span><br><span>@@ -96,7 +96,7 @@</span><br><span>       static struct vlr_subscr arbitrary_vsub = {};</span><br><span>        static bool arbitrary_vsub_set_up = false;</span><br><span>   struct gsm_sms *sms;</span><br><span style="color: hsl(0, 100%, 40%);">-    int i;</span><br><span style="color: hsl(120, 100%, 40%);">+        int i, rc = 0;</span><br><span>       printf("     hitting database: looking for MSISDN > '%s', failed_attempts <= %d\n",</span><br><span>         last_msisdn, max_failed);</span><br><span> </span><br><span>@@ -110,9 +110,10 @@</span><br><span>   * may call vlr_subscr_put() on our arbitrary_vsub, what would</span><br><span>        * lead to a segfault if its use_count <= 0. To prevent this,</span><br><span>      * let's ensure a big enough initial value. */</span><br><span style="color: hsl(0, 100%, 40%);">-      osmo_use_count_get_put(&arbitrary_vsub.use_count, VSUB_USE_SMS_RECEIVER, 1000);</span><br><span style="color: hsl(0, 100%, 40%);">-     osmo_use_count_get_put(&arbitrary_vsub.use_count, VSUB_USE_SMS_PENDING, 1000);</span><br><span style="color: hsl(120, 100%, 40%);">+    rc += osmo_use_count_get_put(&arbitrary_vsub.use_count, VSUB_USE_SMS_RECEIVER, 1000);</span><br><span style="color: hsl(120, 100%, 40%);">+     rc += osmo_use_count_get_put(&arbitrary_vsub.use_count, VSUB_USE_SMS_PENDING, 1000);</span><br><span>     arbitrary_vsub.lu_complete = true;</span><br><span style="color: hsl(120, 100%, 40%);">+    OSMO_ASSERT(rc == 0);</span><br><span> </span><br><span>    for (i = 0; i < ARRAY_SIZE(fake_sms_db); i++) {</span><br><span>           if (!fake_sms_db[i].nr_of_sms)</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/13977">change 13977</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/13977"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-msc </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: merged </div>
<div style="display:none"> Gerrit-Change-Id: I9381e88435ccd856ec619135ca9999c15c25d436 </div>
<div style="display:none"> Gerrit-Change-Number: 13977 </div>
<div style="display:none"> Gerrit-PatchSet: 3 </div>
<div style="display:none"> Gerrit-Owner: Vadim Yanitskiy <axilirator@gmail.com> </div>
<div style="display:none"> Gerrit-Reviewer: Harald Welte <laforge@gnumonks.org> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder (1000002) </div>