<p>Harald Welte <strong>merged</strong> this change.</p><p><a href="https://gerrit.osmocom.org/11838">View Change</a></p><div style="white-space:pre-wrap">Approvals:
  Harald Welte: Looks good to me, approved
  Jenkins Builder: Verified

</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">Fix IMSI padding in imsi-acl<br><br>In I73fd54ad3a4ab8be5aff0fee5c722597ad766e9d incorrect fix was added<br>which only initialize first element of array. Fix this by using explicit<br>index to initialize entire array.<br><br>Change-Id: I26e4aa44f159d1b5b91dda4a586fd4e809711245<br>---<br>M src/gprs/sgsn_vty.c<br>1 file changed, 4 insertions(+), 1 deletion(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/gprs/sgsn_vty.c b/src/gprs/sgsn_vty.c</span><br><span>index 0147b85..c01de3b 100644</span><br><span>--- a/src/gprs/sgsn_vty.c</span><br><span>+++ b/src/gprs/sgsn_vty.c</span><br><span>@@ -636,12 +636,15 @@</span><br><span>      "Remove IMSI from ACL\n"</span><br><span>   "IMSI of subscriber\n")</span><br><span> {</span><br><span style="color: hsl(0, 100%, 40%);">-  char imsi_sanitized[GSM23003_IMSI_MAX_DIGITS + 1] = { '0' };</span><br><span style="color: hsl(120, 100%, 40%);">+  char imsi_sanitized[GSM23003_IMSI_MAX_DIGITS + 1];</span><br><span>   const char *op = argv[0];</span><br><span>    const char *imsi = imsi_sanitized;</span><br><span>   size_t len = strnlen(argv[1], GSM23003_IMSI_MAX_DIGITS + 1);</span><br><span>         int rc;</span><br><span> </span><br><span style="color: hsl(120, 100%, 40%);">+   memset(imsi_sanitized, '0', GSM23003_IMSI_MAX_DIGITS);</span><br><span style="color: hsl(120, 100%, 40%);">+        imsi_sanitized[GSM23003_IMSI_MAX_DIGITS] = '\0';</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span>   /* Sanitize IMSI */</span><br><span>  if (len > GSM23003_IMSI_MAX_DIGITS) {</span><br><span>             vty_out(vty, "%% IMSI (%s) too long (max %u digits) -- ignored!%s",</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/11838">change 11838</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/11838"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-sgsn </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: merged </div>
<div style="display:none"> Gerrit-Change-Id: I26e4aa44f159d1b5b91dda4a586fd4e809711245 </div>
<div style="display:none"> Gerrit-Change-Number: 11838 </div>
<div style="display:none"> Gerrit-PatchSet: 3 </div>
<div style="display:none"> Gerrit-Owner: Max <suraev@alumni.ntnu.no> </div>
<div style="display:none"> Gerrit-Reviewer: Harald Welte <laforge@gnumonks.org> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder (1000002) </div>
<div style="display:none"> Gerrit-Reviewer: Pau Espin Pedrol <pespin@sysmocom.de> </div>