<p>Harald Welte <strong>uploaded patch set #3</strong> to the change originally created by Vadim Yanitskiy.</p><p><a href="https://gerrit.osmocom.org/13974">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">transaction: fix NULL-pointer dereference in trans_alloc()<br><br>Unlike LOG_TRANS_CAT(), LOG_TRANS() is not NULL-safe:<br><br>  LOG_TRANS_CAT(trans, (trans)->log_subsys, level, fmt, ##args)<br>                       ^^^^^^^^^  NULL-pointer dereference<br><br>Let's rather use generic LOGP() macro with pre-calculated logging<br>subsystem. Intentional use of LOG_TRANS_CAT() doesn't make sense<br>anyway, because the result would be uninformative:<br><br>  trans(NULL NULL callref-0x0 tid-0) ...<br><br>Change-Id: I3c373d20ebd6e96ebd57f84b74dc15a6b69c03ac<br>---<br>M include/osmocom/msc/transaction.h<br>M src/libmsc/transaction.c<br>2 files changed, 6 insertions(+), 7 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://gerrit.osmocom.org:29418/osmo-msc refs/changes/74/13974/3</pre><p>To view, visit <a href="https://gerrit.osmocom.org/13974">change 13974</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/13974"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-msc </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: newpatchset </div>
<div style="display:none"> Gerrit-Change-Id: I3c373d20ebd6e96ebd57f84b74dc15a6b69c03ac </div>
<div style="display:none"> Gerrit-Change-Number: 13974 </div>
<div style="display:none"> Gerrit-PatchSet: 3 </div>
<div style="display:none"> Gerrit-Owner: Vadim Yanitskiy <axilirator@gmail.com> </div>
<div style="display:none"> Gerrit-Assignee: Neels Hofmeyr <nhofmeyr@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder (1000002) </div>
<div style="display:none"> Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr@sysmocom.de> </div>
<div style="display:none"> Gerrit-CC: Harald Welte <laforge@gnumonks.org> </div>