<p>Vadim Yanitskiy has uploaded this change for <strong>review</strong>.</p><p><a href="https://gerrit.osmocom.org/14001">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">libmsc/gsm_04_11.c: cosmetic: restructure gsm411_mm_send()<br><br>Change-Id: I22e99f40ab2252a0b716969091e4d24b3b4268a2<br>---<br>M src/libmsc/gsm_04_11.c<br>1 file changed, 2 insertions(+), 4 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://gerrit.osmocom.org:29418/osmo-msc refs/changes/01/14001/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/libmsc/gsm_04_11.c b/src/libmsc/gsm_04_11.c</span><br><span>index cc9ce18..c5c3036 100644</span><br><span>--- a/src/libmsc/gsm_04_11.c</span><br><span>+++ b/src/libmsc/gsm_04_11.c</span><br><span>@@ -216,22 +216,20 @@</span><br><span>        switch (msg_type) {</span><br><span>  case GSM411_MMSMS_EST_REQ:</span><br><span>           rc = gsm411_mmsms_est_req(trans);</span><br><span style="color: hsl(0, 100%, 40%);">-               msgb_free(msg); /* upper layer does not free msg */</span><br><span>          break;</span><br><span>       case GSM411_MMSMS_DATA_REQ:</span><br><span>          rc = gsm411_cp_sendmsg(msg, trans, cp_msg_type);</span><br><span style="color: hsl(0, 100%, 40%);">-                break;</span><br><span style="color: hsl(120, 100%, 40%);">+                return rc; /* gsm411_cp_sendmsg() takes msg ownership */</span><br><span>     case GSM411_MMSMS_REL_REQ:</span><br><span>           LOG_TRANS(trans, LOGL_DEBUG, "Got MMSMS_REL_REQ, destroying transaction.\n");</span><br><span style="color: hsl(0, 100%, 40%);">-         msgb_free(msg);</span><br><span>              trans_free(trans);</span><br><span>           break;</span><br><span>       default:</span><br><span>             LOG_TRANS(trans, LOGL_NOTICE, "Unhandled MMCCSMS msg 0x%x\n", msg_type);</span><br><span style="color: hsl(0, 100%, 40%);">-              msgb_free(msg);</span><br><span>              rc = -EINVAL;</span><br><span>        }</span><br><span> </span><br><span style="color: hsl(120, 100%, 40%);">+ msgb_free(msg);</span><br><span>      return rc;</span><br><span> }</span><br><span> </span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/14001">change 14001</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/14001"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-msc </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>
<div style="display:none"> Gerrit-Change-Id: I22e99f40ab2252a0b716969091e4d24b3b4268a2 </div>
<div style="display:none"> Gerrit-Change-Number: 14001 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Vadim Yanitskiy <axilirator@gmail.com> </div>