<p>Harald Welte has uploaded this change for <strong>review</strong>.</p><p><a href="https://gerrit.osmocom.org/13962">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">Revert "Print error message if application fails to call rate_ctr_init()"<br><br>This reverts commit 9685a48c7bc83b1f5ee9b51e29419164b387ade2 which has<br>caused massive fall-out among (particularly) unit tests in osmo-{msc,bts,pcu}.<br><br>Change-Id: Iede72e86451d94cf678045992cb71f6b1bf16896<br>---<br>M src/rate_ctr.c<br>1 file changed, 2 insertions(+), 5 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/62/13962/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/rate_ctr.c b/src/rate_ctr.c</span><br><span>index 99ec523..026670b 100644</span><br><span>--- a/src/rate_ctr.c</span><br><span>+++ b/src/rate_ctr.c</span><br><span>@@ -69,7 +69,7 @@</span><br><span> #include <osmocom/core/logging.h></span><br><span> </span><br><span> static LLIST_HEAD(rate_ctr_groups);</span><br><span style="color: hsl(0, 100%, 40%);">-static struct osmo_timer_list rate_ctr_timer;</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span> static void *tall_rate_ctr_ctx;</span><br><span> </span><br><span> </span><br><span>@@ -217,10 +217,6 @@</span><br><span>  unsigned int size;</span><br><span>   struct rate_ctr_group *group;</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-       if (!osmo_timer_pending(&rate_ctr_timer))</span><br><span style="color: hsl(0, 100%, 40%);">-           LOGP(DLGLOBAL, LOGL_ERROR, "your program appears to use libosmocore rate_ctr "</span><br><span style="color: hsl(0, 100%, 40%);">-                        "without calling rate_ctr_init() at start-up. Rate counters won't work!\n");</span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span>   if (rate_ctr_get_group_by_name_idx(desc->group_name_prefix, idx)) {</span><br><span>               unsigned int new_idx = rate_ctr_get_unused_name_idx(desc->group_name_prefix);</span><br><span>             LOGP(DLGLOBAL, LOGL_ERROR, "counter group '%s' already exists for index %u,"</span><br><span>@@ -298,6 +294,7 @@</span><br><span>                 ctr->intv[intv+1].rate += ctr->intv[intv].rate;</span><br><span> }</span><br><span> </span><br><span style="color: hsl(120, 100%, 40%);">+static struct osmo_timer_list rate_ctr_timer;</span><br><span> static uint64_t timer_ticks;</span><br><span> </span><br><span> /* The one-second interval has expired */</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/13962">change 13962</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/13962"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: libosmocore </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>
<div style="display:none"> Gerrit-Change-Id: Iede72e86451d94cf678045992cb71f6b1bf16896 </div>
<div style="display:none"> Gerrit-Change-Number: 13962 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Harald Welte <laforge@gnumonks.org> </div>