<p>Neels Hofmeyr has uploaded this change for <strong>review</strong>.</p><p><a href="https://gerrit.osmocom.org/13966">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">silence error messages about HANDOVER_END not permitted<br><br>The MSC_A_EV_HANDOVER_END exists as parent term event for the msc_ho_fsm, but<br>it is not actually required as functional event, since all cleanup is handled<br>in msc_ho_fsm_cleanup().<br><br>That's why I never bothered to add the event to msc_a_fsm, but of course that<br>means we get an error message after each (successful and unsuccessful)<br>handover, that the MSC_A_EV_HANDOVER_END is not permitted.<br><br>Allow the event and ignore it to silence the error message.<br>Explain in a comment.<br><br>Change-Id: Ie8dc0c0a631b7da43111f329562007766a21b134<br>---<br>M src/libmsc/msc_a.c<br>1 file changed, 12 insertions(+), 0 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://gerrit.osmocom.org:29418/osmo-msc refs/changes/66/13966/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/libmsc/msc_a.c b/src/libmsc/msc_a.c</span><br><span>index 77dd43d..5137e20 100644</span><br><span>--- a/src/libmsc/msc_a.c</span><br><span>+++ b/src/libmsc/msc_a.c</span><br><span>@@ -646,6 +646,12 @@</span><br><span>                msc_ho_start(msc_a, (struct ran_handover_required*)data);</span><br><span>            return;</span><br><span> </span><br><span style="color: hsl(120, 100%, 40%);">+   case MSC_A_EV_HANDOVER_END:</span><br><span style="color: hsl(120, 100%, 40%);">+           /* Termination event of the msc_ho_fsm. No action needed, it's all done in the msc_ho_fsm cleanup. This</span><br><span style="color: hsl(120, 100%, 40%);">+            * event only exists because osmo_fsm_inst_alloc_child() requires a parent term event; and maybe</span><br><span style="color: hsl(120, 100%, 40%);">+               * interesting for logging. */</span><br><span style="color: hsl(120, 100%, 40%);">+                return;</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span>    case MSC_A_EV_MO_CLOSE:</span><br><span>      case MSC_A_EV_CN_CLOSE:</span><br><span>      case MSC_A_EV_UNUSED:</span><br><span>@@ -756,6 +762,10 @@</span><br><span>                 /* RTP streams cleaned up above */</span><br><span>           return;</span><br><span> </span><br><span style="color: hsl(120, 100%, 40%);">+   case MSC_A_EV_HANDOVER_END:</span><br><span style="color: hsl(120, 100%, 40%);">+           /* msc_ho_fsm does cleanup. */</span><br><span style="color: hsl(120, 100%, 40%);">+                return;</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span>    default:</span><br><span>             OSMO_ASSERT(false);</span><br><span>  }</span><br><span>@@ -921,6 +931,7 @@</span><br><span>                      | S(MSC_EV_CALL_LEG_TERM)</span><br><span>                    | S(MSC_MNCC_EV_CALL_ENDED)</span><br><span>                  | S(MSC_A_EV_HANDOVER_REQUIRED)</span><br><span style="color: hsl(120, 100%, 40%);">+                       | S(MSC_A_EV_HANDOVER_END)</span><br><span>                   ,</span><br><span>            .out_state_mask = 0</span><br><span>                  | S(MSC_A_ST_RELEASING)</span><br><span>@@ -935,6 +946,7 @@</span><br><span>                        | S(MSC_A_EV_UNUSED)</span><br><span>                         | S(MSC_EV_CALL_LEG_TERM)</span><br><span>                    | S(MSC_MNCC_EV_CALL_ENDED)</span><br><span style="color: hsl(120, 100%, 40%);">+                   | S(MSC_A_EV_HANDOVER_END)</span><br><span>                   ,</span><br><span>            .out_state_mask = 0</span><br><span>                  | S(MSC_A_ST_RELEASED)</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/13966">change 13966</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/13966"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-msc </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>
<div style="display:none"> Gerrit-Change-Id: Ie8dc0c0a631b7da43111f329562007766a21b134 </div>
<div style="display:none"> Gerrit-Change-Number: 13966 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Neels Hofmeyr <nhofmeyr@sysmocom.de> </div>