<p>Harald Welte <strong>merged</strong> this change.</p><p><a href="https://gerrit.osmocom.org/13932">View Change</a></p><div style="white-space:pre-wrap">Approvals:
  Harald Welte: Looks good to me, approved
  Jenkins Builder: Verified

</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">msub_check_for_release(): Initialize msc_role_a_c<br><br>This fixes the following compiler error:<br><br>msub.c: In function ‘msub_fsm_active’:<br>msub.c:85:35: error: ‘msc_role_a_c’ may be used uninitialized in this function<br>[-Werror=maybe-uninitialized]<br>   || (msc_role_a_c && msc_role_a_c->ran->type == OSMO_RAT_EUTRAN_SGS)))<br>                       ~~~~~~~~~~~~^~~~~<br>msub.c:59:26: note: ‘msc_role_a_c’ was declared here<br>  struct msc_role_common *msc_role_a_c;<br>                          ^~~~~~~~~~~~<br><br>Change-Id: Id518dea77d01ed0518ca7cba6b1b363f1c8e6543<br>---<br>M src/libmsc/msub.c<br>1 file changed, 1 insertion(+), 1 deletion(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/libmsc/msub.c b/src/libmsc/msub.c</span><br><span>index 4900732..2021ed8 100644</span><br><span>--- a/src/libmsc/msub.c</span><br><span>+++ b/src/libmsc/msub.c</span><br><span>@@ -56,7 +56,7 @@</span><br><span> static void msub_check_for_release(struct osmo_fsm_inst *fi)</span><br><span> {</span><br><span>      struct msub *msub = fi->priv;</span><br><span style="color: hsl(0, 100%, 40%);">-        struct msc_role_common *msc_role_a_c;</span><br><span style="color: hsl(120, 100%, 40%);">+ struct msc_role_common *msc_role_a_c = NULL;</span><br><span>         enum msc_role role_idx;</span><br><span>      int role_present[MSC_ROLES_COUNT] = {};</span><br><span>      struct osmo_fsm_inst *child;</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/13932">change 13932</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/13932"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-msc </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: merged </div>
<div style="display:none"> Gerrit-Change-Id: Id518dea77d01ed0518ca7cba6b1b363f1c8e6543 </div>
<div style="display:none"> Gerrit-Change-Number: 13932 </div>
<div style="display:none"> Gerrit-PatchSet: 2 </div>
<div style="display:none"> Gerrit-Owner: Harald Welte <laforge@gnumonks.org> </div>
<div style="display:none"> Gerrit-Reviewer: Harald Welte <laforge@gnumonks.org> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder (1000002) </div>
<div style="display:none"> Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr@sysmocom.de> </div>