<p>Neels Hofmeyr has uploaded this change for <strong>review</strong>.</p><p><a href="https://gerrit.osmocom.org/13940">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">no HO call forwarding if no RTP stream<br><br>Fixes: coverity CID 198447<br>Related: OS#3992 (does not fix, just related)<br>Change-Id: Ia223c2e20e625879ab71fc5c8afd0305fd224c58<br>---<br>M src/libmsc/msc_ho.c<br>1 file changed, 5 insertions(+), 0 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://gerrit.osmocom.org:29418/osmo-msc refs/changes/40/13940/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/libmsc/msc_ho.c b/src/libmsc/msc_ho.c</span><br><span>index 9d130c5..3a4258c 100644</span><br><span>--- a/src/libmsc/msc_ho.c</span><br><span>+++ b/src/libmsc/msc_ho.c</span><br><span>@@ -552,6 +552,11 @@</span><br><span>           return -EINVAL;</span><br><span>      }</span><br><span> </span><br><span style="color: hsl(120, 100%, 40%);">+ if (!rtp_to_ran) {</span><br><span style="color: hsl(120, 100%, 40%);">+            msc_ho_failed(msc_a, GSM0808_CAUSE_EQUIPMENT_FAILURE, "Unexpected: no RTP stream is set up\n");</span><br><span style="color: hsl(120, 100%, 40%);">+             return -EINVAL;</span><br><span style="color: hsl(120, 100%, 40%);">+       }</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span>  /* Backup old cell's RTP IP:port and codec data */</span><br><span>       msc_a->ho.old_cell.ran_remote_rtp = rtp_to_ran->remote;</span><br><span>        msc_a->ho.old_cell.codec = rtp_to_ran->codec;</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/13940">change 13940</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/13940"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-msc </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>
<div style="display:none"> Gerrit-Change-Id: Ia223c2e20e625879ab71fc5c8afd0305fd224c58 </div>
<div style="display:none"> Gerrit-Change-Number: 13940 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Neels Hofmeyr <nhofmeyr@sysmocom.de> </div>