<p>Harald Welte <strong>merged</strong> this change.</p><p><a href="https://gerrit.osmocom.org/13935">View Change</a></p><div style="white-space:pre-wrap">Approvals:
  Jenkins Builder: Verified
  Harald Welte: Looks good to me, approved

</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">msc: Don't require protocolExtensions in RANAP Paging<br><br>We were using '?' for the protocolExtensions in RANAP messages,<br>which required that such extensions existed.  In reality, we want<br>to use '*' which accepts paging messages whether or not there<br>are any protocolExtensions present.  As this is the default in<br>all our RANAP receive template, callers don't even need to specify<br>it.<br><br>This should fix all Iu paging related test failures in MSC_Tests*.ttcn<br><br>Change-Id: If22e16ecb301c86b9073ffde0af9e03bc85fbcc7<br>---<br>M msc/BSC_ConnectionHandler.ttcn<br>M msc/MSC_Tests.ttcn<br>2 files changed, 4 insertions(+), 4 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/msc/BSC_ConnectionHandler.ttcn b/msc/BSC_ConnectionHandler.ttcn</span><br><span>index 1cec69c..9fc0616 100644</span><br><span>--- a/msc/BSC_ConnectionHandler.ttcn</span><br><span>+++ b/msc/BSC_ConnectionHandler.ttcn</span><br><span>@@ -766,7 +766,7 @@</span><br><span>     if (g_pars.ran_is_geran) {</span><br><span>           BSSAP.receive(tr_BSSMAP_Paging(g_pars.imsi));</span><br><span>        } else {</span><br><span style="color: hsl(0, 100%, 40%);">-                BSSAP.receive(tr_RANAP_Paging(cs_domain, imsi_hex2oct(g_pars.imsi), ?));</span><br><span style="color: hsl(120, 100%, 40%);">+              BSSAP.receive(tr_RANAP_Paging(cs_domain, imsi_hex2oct(g_pars.imsi)));</span><br><span>        }</span><br><span> }</span><br><span> </span><br><span>diff --git a/msc/MSC_Tests.ttcn b/msc/MSC_Tests.ttcn</span><br><span>index 3a6711b..52aa685 100644</span><br><span>--- a/msc/MSC_Tests.ttcn</span><br><span>+++ b/msc/MSC_Tests.ttcn</span><br><span>@@ -2127,7 +2127,7 @@</span><br><span>                      setverdict(fail, "paging seems not to stop!");</span><br><span>                     mtc.stop;</span><br><span>            }</span><br><span style="color: hsl(0, 100%, 40%);">-               [not pars.ran_is_geran] BSSAP.receive(tr_RANAP_Paging(cs_domain, imsi_hex2oct(g_pars.imsi), ?)) {</span><br><span style="color: hsl(120, 100%, 40%);">+             [not pars.ran_is_geran] BSSAP.receive(tr_RANAP_Paging(cs_domain, imsi_hex2oct(g_pars.imsi))) {</span><br><span>                       setverdict(fail, "paging seems not to stop!");</span><br><span>                     mtc.stop;</span><br><span>            }</span><br><span>@@ -3070,7 +3070,7 @@</span><br><span>    [pars.ran_is_geran] BSSAP.receive(tr_BSSMAP_Paging(g_pars.imsi)) {</span><br><span>           setverdict(pass);</span><br><span>            }</span><br><span style="color: hsl(0, 100%, 40%);">-       [not pars.ran_is_geran] BSSAP.receive(tr_RANAP_Paging(cs_domain, imsi_hex2oct(g_pars.imsi), ?)) {</span><br><span style="color: hsl(120, 100%, 40%);">+     [not pars.ran_is_geran] BSSAP.receive(tr_RANAP_Paging(cs_domain, imsi_hex2oct(g_pars.imsi))) {</span><br><span>               setverdict(pass);</span><br><span>            }</span><br><span>    /* We don't expect anything else */</span><br><span>@@ -3677,7 +3677,7 @@</span><br><span>      [g_pars.ran_is_geran] BSSAP.receive(tr_BSSMAP_Paging(g_pars.imsi)); {</span><br><span>                setverdict(pass);</span><br><span>            }</span><br><span style="color: hsl(0, 100%, 40%);">-       [not g_pars.ran_is_geran] BSSAP.receive(tr_RANAP_Paging(cs_domain, imsi_hex2oct(g_pars.imsi), ?)) {</span><br><span style="color: hsl(120, 100%, 40%);">+   [not g_pars.ran_is_geran] BSSAP.receive(tr_RANAP_Paging(cs_domain, imsi_hex2oct(g_pars.imsi))) {</span><br><span>             setverdict(pass);</span><br><span>            }</span><br><span>    [] SGsAP.receive {</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/13935">change 13935</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/13935"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-ttcn3-hacks </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: merged </div>
<div style="display:none"> Gerrit-Change-Id: If22e16ecb301c86b9073ffde0af9e03bc85fbcc7 </div>
<div style="display:none"> Gerrit-Change-Number: 13935 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Harald Welte <laforge@gnumonks.org> </div>
<div style="display:none"> Gerrit-Reviewer: Harald Welte <laforge@gnumonks.org> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder (1000002) </div>