<p>Harald Welte <strong>merged</strong> this change.</p><p><a href="https://gerrit.osmocom.org/13936">View Change</a></p><div style="white-space:pre-wrap">Approvals:
  Jenkins Builder: Verified
  Harald Welte: Looks good to me, approved

</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">msc: Permit optional authentication before reject/timeout<br><br>Tests like TC_lu_imsi_reject, TC_lu_imsi_timeout_gsup and<br>TC_cmserv_imsi_unknown all expected a reject straight in response<br>to the LU REQ / CM SERV REQ.  However, the MSC may very well decide<br>to perform authentication beforehand.  It's an implementation<br>detail when a MSC/VLR performs authentication, so the tests should<br>be tolerant to this.<br><br>This primarily shows up in 3G/Iu/RANAP related tests, as authentication<br>is mandatory there.<br><br>Change-Id: Icdd3f34eca08092703ab2ba9a8e755e2d609a59b<br>---<br>M msc/MSC_Tests.ttcn<br>1 file changed, 3 insertions(+), 0 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/msc/MSC_Tests.ttcn b/msc/MSC_Tests.ttcn</span><br><span>index 52aa685..e1e5088 100644</span><br><span>--- a/msc/MSC_Tests.ttcn</span><br><span>+++ b/msc/MSC_Tests.ttcn</span><br><span>@@ -583,6 +583,7 @@</span><br><span> </span><br><span>      f_create_gsup_expect(hex2str(g_pars.imsi));</span><br><span>  f_cl3_or_initial_ue(l3_lu);</span><br><span style="color: hsl(120, 100%, 40%);">+   f_mm_auth();</span><br><span>         GSUP.receive(tr_GSUP_UL_REQ(g_pars.imsi));</span><br><span>   GSUP.send(ts_GSUP_UL_ERR(g_pars.imsi, 23));</span><br><span>  alt {</span><br><span>@@ -612,6 +613,7 @@</span><br><span> </span><br><span>      f_create_gsup_expect(hex2str(g_pars.imsi));</span><br><span>  f_cl3_or_initial_ue(l3_lu);</span><br><span style="color: hsl(120, 100%, 40%);">+   f_mm_auth();</span><br><span>         GSUP.receive(tr_GSUP_UL_REQ(g_pars.imsi));</span><br><span>   /* Normally the HLR would need to respond here, but we decide to force a timeout here */</span><br><span>     alt {</span><br><span>@@ -678,6 +680,7 @@</span><br><span> </span><br><span>      /* Send BSSAP_Conn_Req with COMPL L3 INFO to MSC */</span><br><span>  f_cl3_or_initial_ue(l3_info);</span><br><span style="color: hsl(120, 100%, 40%);">+ f_mm_auth();</span><br><span> </span><br><span>     timer T := 10.0;</span><br><span>     T.start;</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/13936">change 13936</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/13936"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-ttcn3-hacks </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: merged </div>
<div style="display:none"> Gerrit-Change-Id: Icdd3f34eca08092703ab2ba9a8e755e2d609a59b </div>
<div style="display:none"> Gerrit-Change-Number: 13936 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Harald Welte <laforge@gnumonks.org> </div>
<div style="display:none"> Gerrit-Reviewer: Harald Welte <laforge@gnumonks.org> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder (1000002) </div>