<p>Vadim Yanitskiy has uploaded this change for <strong>review</strong>.</p><p><a href="https://gerrit.osmocom.org/13957">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">trxcon/trx_if.c: print error message if read() call fails<br><br>Change-Id: If3aaa730c306e703d1d430a8920284aa592c999c<br>---<br>M src/host/trxcon/trx_if.c<br>1 file changed, 6 insertions(+), 2 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://gerrit.osmocom.org:29418/osmocom-bb refs/changes/57/13957/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/host/trxcon/trx_if.c b/src/host/trxcon/trx_if.c</span><br><span>index 91075f4..e53fab2 100644</span><br><span>--- a/src/host/trxcon/trx_if.c</span><br><span>+++ b/src/host/trxcon/trx_if.c</span><br><span>@@ -444,8 +444,10 @@</span><br><span>      char buf[1500], *p;</span><br><span> </span><br><span>      len = read(ofd->fd, buf, sizeof(buf) - 1);</span><br><span style="color: hsl(0, 100%, 40%);">-   if (len <= 0)</span><br><span style="color: hsl(120, 100%, 40%);">+      if (len <= 0) {</span><br><span style="color: hsl(120, 100%, 40%);">+            LOGP(DTRX, LOGL_ERROR, "read() failed with rc=%d\n", len);</span><br><span>                 return len;</span><br><span style="color: hsl(120, 100%, 40%);">+   }</span><br><span>    buf[len] = '\0';</span><br><span> </span><br><span>         if (!!strncmp(buf, "RSP ", 4)) {</span><br><span>@@ -551,8 +553,10 @@</span><br><span>    int len;</span><br><span> </span><br><span>         len = read(ofd->fd, buf, sizeof(buf));</span><br><span style="color: hsl(0, 100%, 40%);">-       if (len <= 0)</span><br><span style="color: hsl(120, 100%, 40%);">+      if (len <= 0) {</span><br><span style="color: hsl(120, 100%, 40%);">+            LOGP(DTRXD, LOGL_ERROR, "read() failed with rc=%d\n", len);</span><br><span>                return len;</span><br><span style="color: hsl(120, 100%, 40%);">+   }</span><br><span> </span><br><span>        if (len != 158) {</span><br><span>            LOGP(DTRXD, LOGL_ERROR, "Got data message with invalid "</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/13957">change 13957</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/13957"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmocom-bb </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>
<div style="display:none"> Gerrit-Change-Id: If3aaa730c306e703d1d430a8920284aa592c999c </div>
<div style="display:none"> Gerrit-Change-Number: 13957 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Vadim Yanitskiy <axilirator@gmail.com> </div>