<p>Pau Espin Pedrol has uploaded this change for <strong>review</strong>.</p><p><a href="https://gerrit.osmocom.org/13884">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">mgcp_osmux.c: osmux_enable_endpoint: Fix incorrect return check<br><br>osmux_xfrm_input_open_circuit returns 0 on success and -1 on error.<br>Confusion comes from that function being implemented by calling<br>osmux_batch_add_circuit which returns NULL on error.<br><br>cherry-picked from: openbsc.git ac1b03c8e59408336d07527e2597171cb99ed654.<br><br>Change-Id: Iba018aa57901642ea4c486526a973fe6023e10cf<br>---<br>M src/libosmo-mgcp/mgcp_osmux.c<br>1 file changed, 1 insertion(+), 1 deletion(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://gerrit.osmocom.org:29418/osmo-mgw refs/changes/84/13884/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/libosmo-mgcp/mgcp_osmux.c b/src/libosmo-mgcp/mgcp_osmux.c</span><br><span>index 3bd765e..7e26d7a 100644</span><br><span>--- a/src/libosmo-mgcp/mgcp_osmux.c</span><br><span>+++ b/src/libosmo-mgcp/mgcp_osmux.c</span><br><span>@@ -567,7 +567,7 @@</span><br><span>                     mgcp_conn_dump(conn->conn));</span><br><span>                 return -1;</span><br><span>   }</span><br><span style="color: hsl(0, 100%, 40%);">-       if (!osmux_xfrm_input_open_circuit(conn->osmux.in, conn->osmux.cid, osmux_dummy)) {</span><br><span style="color: hsl(120, 100%, 40%);">+     if (osmux_xfrm_input_open_circuit(conn->osmux.in, conn->osmux.cid, osmux_dummy) < 0) {</span><br><span>              LOGP(DLMGCP, LOGL_ERROR, "Cannot open osmux circuit %u for conn:%s\n",</span><br><span>                  conn->osmux.cid, mgcp_conn_dump(conn->conn));</span><br><span>             return -1;</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/13884">change 13884</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/13884"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-mgw </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>
<div style="display:none"> Gerrit-Change-Id: Iba018aa57901642ea4c486526a973fe6023e10cf </div>
<div style="display:none"> Gerrit-Change-Number: 13884 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Pau Espin Pedrol <pespin@sysmocom.de> </div>