<p>Harald Welte <strong>merged</strong> this change.</p><p><a href="https://gerrit.osmocom.org/13855">View Change</a></p><div style="white-space:pre-wrap">Approvals:
  Jenkins Builder: Verified
  Harald Welte: Looks good to me, approved

</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">mobile/gsm322.c: fix heap-use-after-free in gsm322_unselect_cell()<br><br>In gsm322_l1_signal(), if S_L1CTL_FBSB_ERR is received, we free<br>stored System Information of the current cell, but cs->si may<br>still point to it. Let's set it to NULL.<br><br>Found with AddressSanitizer:<br><br>  DL1C ERROR l1ctl.c:96 FBSB RESP: result=255<br>  DCS INFO gsm322.c:2995 Channel sync error, try again<br>  DCS INFO gsm322.c:467 Sync to ARFCN=860(DCS) rxlev=-106<br>  DRR INFO gsm48_rr.c:665 MON: no cell info<br>  DRR INFO gsm48_rr.c:665 MON: no cell info<br>  DRR INFO gsm48_rr.c:665 MON: no cell info<br>  DRR INFO gsm48_rr.c:665 MON: no cell info<br>  DL1C ERROR l1ctl.c:96 FBSB RESP: result=255<br>  DCS INFO gsm322.c:3008 Channel sync error.<br>  DCS DEBUG gsm322.c:3013 free sysinfo ARFCN=860(DCS)<br>  DCS INFO gsm322.c:3020 Unselect cell due to sync error!<br>  DCS INFO gsm322.c:509 Unselecting serving cell.<br>  =================================================================<br>  ==6014==ERROR: AddressSanitizer: heap-use-after-free on address<br>                 0x61b0000000e6 at pc 0x00000050d6dd<br>                bp 0x7fff7f84aa60 sp 0x7fff7f84aa58<br><br>Change-Id: I9cc526c18d69695d810de98703579818408de011<br>---<br>M src/host/layer23/src/mobile/gsm322.c<br>1 file changed, 2 insertions(+), 0 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/host/layer23/src/mobile/gsm322.c b/src/host/layer23/src/mobile/gsm322.c</span><br><span>index 7da63e3..bfe6329 100644</span><br><span>--- a/src/host/layer23/src/mobile/gsm322.c</span><br><span>+++ b/src/host/layer23/src/mobile/gsm322.c</span><br><span>@@ -3011,6 +3011,8 @@</span><br><span>                       cs->list[cs->arfci].flags &= ~GSM322_CS_FLAG_SYSINFO;</span><br><span>                      LOGP(DCS, LOGL_DEBUG, "free sysinfo ARFCN=%s\n",</span><br><span>                           gsm_print_arfcn(index2arfcn(cs->arfci)));</span><br><span style="color: hsl(120, 100%, 40%);">+                  if (cs->si == cs->list[cs->arfci].sysinfo)</span><br><span style="color: hsl(120, 100%, 40%);">+                           cs->si = NULL;</span><br><span>                    talloc_free(cs->list[cs->arfci].sysinfo);</span><br><span>                      cs->list[cs->arfci].sysinfo = NULL;</span><br><span> </span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/13855">change 13855</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/13855"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmocom-bb </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: merged </div>
<div style="display:none"> Gerrit-Change-Id: I9cc526c18d69695d810de98703579818408de011 </div>
<div style="display:none"> Gerrit-Change-Number: 13855 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Vadim Yanitskiy <axilirator@gmail.com> </div>
<div style="display:none"> Gerrit-Reviewer: Harald Welte <laforge@gnumonks.org> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder (1000002) </div>