<p>Vadim Yanitskiy has uploaded this change for <strong>review</strong>.</p><p><a href="https://gerrit.osmocom.org/13856">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">mobile/gsm48_rr.h: mark gsm48_rr_hdr struct as packed<br><br>In both gsm48_mm.c and gsm48_rr.c we put / push 'gsm48_rr_hdr'<br>structure into the message buffers, so then it's retrieved by<br>the message receivers. The AddressSanitizer complains about<br>unaligned pointer access and potentially unexpected behaviour.<br><br>Change-Id: I8aa2c0074b405afd0e76044ef076b6819fe1083b<br>---<br>M src/host/layer23/include/osmocom/bb/mobile/gsm48_rr.h<br>1 file changed, 1 insertion(+), 1 deletion(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://gerrit.osmocom.org:29418/osmocom-bb refs/changes/56/13856/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/host/layer23/include/osmocom/bb/mobile/gsm48_rr.h b/src/host/layer23/include/osmocom/bb/mobile/gsm48_rr.h</span><br><span>index 6235bfd..6996ff3 100644</span><br><span>--- a/src/host/layer23/include/osmocom/bb/mobile/gsm48_rr.h</span><br><span>+++ b/src/host/layer23/include/osmocom/bb/mobile/gsm48_rr.h</span><br><span>@@ -61,7 +61,7 @@</span><br><span>    uint32_t                msg_type; /* RR-* primitive */</span><br><span>       uint8_t                 sapi;</span><br><span>        uint8_t                 cause;</span><br><span style="color: hsl(0, 100%, 40%);">-};</span><br><span style="color: hsl(120, 100%, 40%);">+} __attribute__((packed));</span><br><span> </span><br><span> /* GSM 04.07 9.1.1 */</span><br><span> #define GSM48_RR_ST_IDLE           0</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/13856">change 13856</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/13856"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmocom-bb </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>
<div style="display:none"> Gerrit-Change-Id: I8aa2c0074b405afd0e76044ef076b6819fe1083b </div>
<div style="display:none"> Gerrit-Change-Number: 13856 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Vadim Yanitskiy <axilirator@gmail.com> </div>