<p>Harald Welte <strong>merged</strong> this change.</p><p><a href="https://gerrit.osmocom.org/13811">View Change</a></p><div style="white-space:pre-wrap">Approvals:
  Harald Welte: Looks good to me, approved; Verified
  Keith Whyte: Looks good to me, but someone else must approve
  Jenkins Builder: Verified

</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">Echo zero byte XID-Field of Type L3_PAR<br><br>After Activate PDP Context request, Motorola KRZR<br>sends a zero length XID-Field of Type L3 Parameters<br><br>If this is not echoed back, the phone will send<br>Deactivate PDP Context request with SM Cause:<br>LLC or SNDCP failure(A/Gb only) (25)<br><br>Closes: OS#3426<br><br>Change-Id: Ibd75f7b943c84ed7264481fa2e4bc3cb2f6745d4<br>---<br>M src/gprs/gprs_sndcp.c<br>1 file changed, 8 insertions(+), 0 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/gprs/gprs_sndcp.c b/src/gprs/gprs_sndcp.c</span><br><span>index 23d1e9a..d9aa1e5 100644</span><br><span>--- a/src/gprs/gprs_sndcp.c</span><br><span>+++ b/src/gprs/gprs_sndcp.c</span><br><span>@@ -1120,6 +1120,14 @@</span><br><span>       OSMO_ASSERT(xid_field_response);</span><br><span>     OSMO_ASSERT(lle);</span><br><span> </span><br><span style="color: hsl(120, 100%, 40%);">+ /* Some phones send zero byte length SNDCP frames</span><br><span style="color: hsl(120, 100%, 40%);">+      * and do require a confirmation response. */</span><br><span style="color: hsl(120, 100%, 40%);">+ if (xid_field_indication->data_len == 0) {</span><br><span style="color: hsl(120, 100%, 40%);">+         xid_field_response->type = GPRS_LLC_XID_T_L3_PAR;</span><br><span style="color: hsl(120, 100%, 40%);">+          xid_field_response->data_len = 0;</span><br><span style="color: hsl(120, 100%, 40%);">+          return 0;</span><br><span style="color: hsl(120, 100%, 40%);">+     }</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span>  /* Parse SNDCP-CID XID-Field */</span><br><span>      comp_fields = gprs_sndcp_parse_xid(&version, lle->llme,</span><br><span>                                          xid_field_indication->data,</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/13811">change 13811</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/13811"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-sgsn </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: merged </div>
<div style="display:none"> Gerrit-Change-Id: Ibd75f7b943c84ed7264481fa2e4bc3cb2f6745d4 </div>
<div style="display:none"> Gerrit-Change-Number: 13811 </div>
<div style="display:none"> Gerrit-PatchSet: 8 </div>
<div style="display:none"> Gerrit-Owner: Keith Whyte <keith@rhizomatica.org> </div>
<div style="display:none"> Gerrit-Reviewer: Harald Welte <laforge@gnumonks.org> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder (1000002) </div>
<div style="display:none"> Gerrit-Reviewer: Keith Whyte <keith@rhizomatica.org> </div>
<div style="display:none"> Gerrit-Reviewer: lynxis lazus <lynxis@fe80.eu> </div>
<div style="display:none"> Gerrit-CC: Pau Espin Pedrol <pespin@sysmocom.de> </div>