<p>Piotr Krysik <strong>merged</strong> this change.</p><p><a href="https://gerrit.osmocom.org/13671">View Change</a></p><div style="white-space:pre-wrap">Approvals:
Piotr Krysik: Looks good to me, approved; Verified
</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">Improve the TCH/H decoder logs<br><br>- Change "6,90 kbit/s" to "5.9 kbit/s"<br> A typo reported in github ptrkrysik/gr-gsm#456<br>- Comment out the "Error! frame_nr:" message as it turns out to confuse<br> users more then it actually helps debugging.<br>- When voice-boundary detection is enabled write the name of decoded<br> control channel messages<br><br>Change-Id: I697ef944f30c4cabb62c888317dd3a7f8dcd5611<br>---<br>M lib/decoding/tch_h_decoder_impl.cc<br>1 file changed, 8 insertions(+), 1 deletion(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/lib/decoding/tch_h_decoder_impl.cc b/lib/decoding/tch_h_decoder_impl.cc</span><br><span>index 11da907..b6827f7 100644</span><br><span>--- a/lib/decoding/tch_h_decoder_impl.cc</span><br><span>+++ b/lib/decoding/tch_h_decoder_impl.cc</span><br><span>@@ -178,7 +178,7 @@</span><br><span> std::cout<<"5,15 kbit/s codec rate: is part of the subset"<<std::endl;</span><br><span> break;</span><br><span> case 2:</span><br><span style="color: hsl(0, 100%, 40%);">- std::cout<<"6,90 kbit/s codec rate: is part of the subset"<<std::endl;</span><br><span style="color: hsl(120, 100%, 40%);">+ std::cout<<"5,90 kbit/s codec rate: is part of the subset"<<std::endl;</span><br><span> break;</span><br><span> case 3:</span><br><span> std::cout<<"6,70 kbit/s codec rate: is part of the subset"<<std::endl;</span><br><span>@@ -266,10 +266,12 @@</span><br><span> </span><br><span> if (frameLength < 12)</span><br><span> {</span><br><span style="color: hsl(120, 100%, 40%);">+ #if 0</span><br><span> if (!d_boundary_check || d_boundary_decode) {</span><br><span> std::cerr<<"Error! frame_nr:"<<frame_nr<<" mod26:"<<frame_nr%26</span><br><span> <<" fn_is_odd:"<<fn_is_odd<<" length:"<<frameLength<<std::endl;</span><br><span> }</span><br><span style="color: hsl(120, 100%, 40%);">+ #endif</span><br><span> return;</span><br><span> }</span><br><span> else if (frameLength == GSM_MACBLOCK_LEN) //FACCH/H</span><br><span>@@ -301,6 +303,7 @@</span><br><span> (frameBuffer[6] == 2) && //length</span><br><span> ((frameBuffer[8] & 0x7f) == 0x08))</span><br><span> {</span><br><span style="color: hsl(120, 100%, 40%);">+ std::cout << "(CC) Alerting with In-band information" << std::endl;</span><br><span> //.000 1000 = Progress description: In-band information or appropriate pattern now available (8)</span><br><span> d_boundary_decode = true;</span><br><span> }</span><br><span>@@ -311,6 +314,7 @@</span><br><span> if ((frameBuffer[5] == 2) && //length</span><br><span> (frameBuffer[7] & 0x7f) == 0x08)</span><br><span> {</span><br><span style="color: hsl(120, 100%, 40%);">+ std::cout << "(CC) Progress with In-band information" << std::endl;</span><br><span> //.000 1000 = Progress description: In-band information or appropriate pattern now available (8)</span><br><span> d_boundary_decode = true;</span><br><span> }</span><br><span>@@ -318,16 +322,19 @@</span><br><span> // Connect specified in GSM 04.08, 9.3.5</span><br><span> else if ((frameBuffer[4] & 0x3f) == 0x07)</span><br><span> {</span><br><span style="color: hsl(120, 100%, 40%);">+ std::cout << "(CC) Connect" << std::endl;</span><br><span> d_boundary_decode = true;</span><br><span> }</span><br><span> // Connect Acknowledge specified in GSM 04.08, 9.3.6</span><br><span> else if ((frameBuffer[4] & 0x3f) == 0x0f)</span><br><span> {</span><br><span style="color: hsl(120, 100%, 40%);">+ std::cout << "(CC) Connect Acknowledge" << std::endl;</span><br><span> d_boundary_decode = true;</span><br><span> }</span><br><span> // Release specified in GSM 04.08, 9.3.18</span><br><span> else if ((frameBuffer[4] & 0x3f) == 0x2d)</span><br><span> {</span><br><span style="color: hsl(120, 100%, 40%);">+ std::cout << "(CC) Release" << std::endl;</span><br><span> d_boundary_decode = false;</span><br><span> }</span><br><span> }</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/13671">change 13671</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/13671"/><meta itemprop="name" content="View Change"/></div></div>
<div style="display:none"> Gerrit-Project: gr-gsm </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: merged </div>
<div style="display:none"> Gerrit-Change-Id: I697ef944f30c4cabb62c888317dd3a7f8dcd5611 </div>
<div style="display:none"> Gerrit-Change-Number: 13671 </div>
<div style="display:none"> Gerrit-PatchSet: 3 </div>
<div style="display:none"> Gerrit-Owner: Vasil Velichkov <vvvelichkov@gmail.com> </div>
<div style="display:none"> Gerrit-Reviewer: Piotr Krysik <ptrkrysik@gmail.com> </div>
<div style="display:none"> Gerrit-Reviewer: Vadim Yanitskiy <axilirator@gmail.com> </div>