<p>Holger Freyther <strong>merged</strong> this change.</p><p><a href="https://gerrit.osmocom.org/13823">View Change</a></p><div style="white-space:pre-wrap">Approvals:
Harald Welte: Looks good to me, but someone else must approve
Pau Espin Pedrol: Looks good to me, approved
Jenkins Builder: Verified
</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">virtual: Separate starting virtphy/mobile from the test<br><br>Move the starting code out of the Update Location "test". In the mid<br>term we can have a SMS test run in addition to waiting the Update<br>Location tests.<br><br>A mass-test testcase will have a life-cycle of:<br><br> * Creation<br> * Configure (number of subscribers, probably all subs)<br> * Pre-Start trigger (same as configure so it can be omitted)<br> * Post-Start (all processes run)<br> * Query if the test has completed<br><br>The next step is an actual implementation to send SMS.<br><br>Change-Id: Ie15f5123775d11dd44243b2741d047ed93f318f9<br>---<br>M src/osmo_gsm_tester/ms_driver.py<br>M src/osmo_ms_driver/__main__.py<br>M src/osmo_ms_driver/location_update_test.py<br>3 files changed, 114 insertions(+), 79 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/osmo_gsm_tester/ms_driver.py b/src/osmo_gsm_tester/ms_driver.py</span><br><span>index 3cfcad6..329662a 100644</span><br><span>--- a/src/osmo_gsm_tester/ms_driver.py</span><br><span>+++ b/src/osmo_gsm_tester/ms_driver.py</span><br><span>@@ -20,7 +20,7 @@</span><br><span> from osmo_ms_driver.cdf import cdfs</span><br><span> from osmo_ms_driver.event_server import EventServer</span><br><span> from osmo_ms_driver.simple_loop import SimpleLoop</span><br><span style="color: hsl(0, 100%, 40%);">-from osmo_ms_driver.location_update_test import MassUpdateLocationTest</span><br><span style="color: hsl(120, 100%, 40%);">+from osmo_ms_driver.location_update_test import MassUpdateLocationTest, MobileTestStarter</span><br><span> from osmo_ms_driver.starter import BinaryOptions</span><br><span> </span><br><span> import os.path</span><br><span>@@ -92,14 +92,18 @@</span><br><span> </span><br><span> self._ev_server = EventServer("ev_server", event_server_path)</span><br><span> self._ev_server.listen(self._loop)</span><br><span style="color: hsl(120, 100%, 40%);">+ self._results = {}</span><br><span> options = self.build_binary_options()</span><br><span style="color: hsl(0, 100%, 40%);">- self._test_case = MassUpdateLocationTest("mass", options, self._cdf,</span><br><span style="color: hsl(0, 100%, 40%);">- self._ev_server,</span><br><span style="color: hsl(0, 100%, 40%);">- util.Dir(self.event_server_sk_tmp_dir),</span><br><span style="color: hsl(0, 100%, 40%);">- suite_run=self._suite_run)</span><br><span style="color: hsl(120, 100%, 40%);">+ self._starter = MobileTestStarter("mass", options, self._cdf,</span><br><span style="color: hsl(120, 100%, 40%);">+ self._ev_server,</span><br><span style="color: hsl(120, 100%, 40%);">+ util.Dir(self.event_server_sk_tmp_dir),</span><br><span style="color: hsl(120, 100%, 40%);">+ self._results, suite_run=self._suite_run)</span><br><span style="color: hsl(120, 100%, 40%);">+ self._test_case = MassUpdateLocationTest("mass", self._ev_server, self._results)</span><br><span> </span><br><span> for sub in self._subscribers:</span><br><span style="color: hsl(0, 100%, 40%);">- self._test_case.subscriber_add(sub)</span><br><span style="color: hsl(120, 100%, 40%);">+ self._starter.subscriber_add(sub)</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ self._test_case.configure(len(self._subscribers))</span><br><span> self._configured = True</span><br><span> </span><br><span> def run_test(self):</span><br><span>@@ -110,7 +114,8 @@</span><br><span> """</span><br><span> if not self._configured:</span><br><span> self.configure()</span><br><span style="color: hsl(0, 100%, 40%);">- self._test_case.run_test(self._loop, self._test_duration)</span><br><span style="color: hsl(120, 100%, 40%);">+ deadline = self._starter.start_all(self._loop, self._test_duration)</span><br><span style="color: hsl(120, 100%, 40%);">+ self._test_case.wait_for_test(self._loop, deadline)</span><br><span> </span><br><span> def print_stats(self):</span><br><span> """</span><br><span>diff --git a/src/osmo_ms_driver/__main__.py b/src/osmo_ms_driver/__main__.py</span><br><span>index d753897..642002f 100644</span><br><span>--- a/src/osmo_ms_driver/__main__.py</span><br><span>+++ b/src/osmo_ms_driver/__main__.py</span><br><span>@@ -18,7 +18,7 @@</span><br><span> # Local modules</span><br><span> from .event_server import EventServer</span><br><span> from .simple_loop import SimpleLoop</span><br><span style="color: hsl(0, 100%, 40%);">-from .location_update_test import MassUpdateLocationTest</span><br><span style="color: hsl(120, 100%, 40%);">+from .location_update_test import MassUpdateLocationTest, MobileTestStarter</span><br><span> from .cdf import cdfs</span><br><span> from .starter import BinaryOptions</span><br><span> from .test_support import imsi_ki_gen</span><br><span>@@ -86,7 +86,9 @@</span><br><span> </span><br><span> # Just a single test for now.</span><br><span> options = BinaryOptions("virtphy", "mobile", os.environ)</span><br><span style="color: hsl(0, 100%, 40%);">- test = MassUpdateLocationTest("lu_test", options, cdf, ev_server, tmp_dir)</span><br><span style="color: hsl(120, 100%, 40%);">+ result = {}</span><br><span style="color: hsl(120, 100%, 40%);">+ starter = MobileTestStarter("lu_test", options, cdf, ev_server, tmp_dir, result)</span><br><span style="color: hsl(120, 100%, 40%);">+ test = MassUpdateLocationTest("lu_test", ev_server, result)</span><br><span> </span><br><span> # Add subscribers to the test.</span><br><span> imsi_gen = imsi_ki_gen()</span><br><span>@@ -97,12 +99,14 @@</span><br><span> 'ki': ki,</span><br><span> 'auth_algo': 'comp128v1',</span><br><span> }</span><br><span style="color: hsl(0, 100%, 40%);">- test.subscriber_add(ms_osmo_mobile.MSOsmoMobile("ms_%d" % i, conf))</span><br><span style="color: hsl(120, 100%, 40%);">+ starter.subscriber_add(ms_osmo_mobile.MSOsmoMobile("ms_%d" % i, conf))</span><br><span style="color: hsl(120, 100%, 40%);">+ test.configure(args.num_ms)</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">- atexit.register(test.stop_all)</span><br><span style="color: hsl(120, 100%, 40%);">+ atexit.register(starter.stop_all)</span><br><span> </span><br><span> # Run until everything has been launched</span><br><span style="color: hsl(0, 100%, 40%);">- test.run_test(loop, timedelta(seconds=args.test_duration))</span><br><span style="color: hsl(120, 100%, 40%);">+ deadline = starter.start_all(loop, timedelta(seconds=args.test_duration))</span><br><span style="color: hsl(120, 100%, 40%);">+ test.wait_for_test(loop, deadline)</span><br><span> </span><br><span> # Print stats</span><br><span> test.print_stats()</span><br><span>diff --git a/src/osmo_ms_driver/location_update_test.py b/src/osmo_ms_driver/location_update_test.py</span><br><span>index 29abf73..efb161e 100644</span><br><span>--- a/src/osmo_ms_driver/location_update_test.py</span><br><span>+++ b/src/osmo_ms_driver/location_update_test.py</span><br><span>@@ -24,6 +24,7 @@</span><br><span> from datetime import timedelta</span><br><span> </span><br><span> import collections</span><br><span style="color: hsl(120, 100%, 40%);">+import json</span><br><span> import time</span><br><span> </span><br><span> # Key used for the result dictionary</span><br><span>@@ -58,6 +59,85 @@</span><br><span> "min_latency", "max_latency"])</span><br><span> </span><br><span> class MassUpdateLocationTest(log.Origin):</span><br><span style="color: hsl(120, 100%, 40%);">+ def __init__(self, name, event_server, results):</span><br><span style="color: hsl(120, 100%, 40%);">+ super().__init__(log.C_RUN, name)</span><br><span style="color: hsl(120, 100%, 40%);">+ self._event_server = event_server</span><br><span style="color: hsl(120, 100%, 40%);">+ self._event_server.register(self.handle_msg)</span><br><span style="color: hsl(120, 100%, 40%);">+ self._results = results</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ def configure(self, num_subscribers):</span><br><span style="color: hsl(120, 100%, 40%);">+ self._num_subscribers = num_subscribers</span><br><span style="color: hsl(120, 100%, 40%);">+ self._outstanding = num_subscribers</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ def handle_msg(self, _data, addr, time):</span><br><span style="color: hsl(120, 100%, 40%);">+ data = json.loads(_data.decode())</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ if data['type'] == 'event':</span><br><span style="color: hsl(120, 100%, 40%);">+ if data['data']['lu_done'] == 1:</span><br><span style="color: hsl(120, 100%, 40%);">+ ms = self._results[data['ms']]</span><br><span style="color: hsl(120, 100%, 40%);">+ if not has_lu_time(ms):</span><br><span style="color: hsl(120, 100%, 40%);">+ self._outstanding = self._outstanding - 1</span><br><span style="color: hsl(120, 100%, 40%);">+ set_lu_time(ms, time)</span><br><span style="color: hsl(120, 100%, 40%);">+ self.log("MS performed LU ", ms=ms, at=time, lu_delay=lu_delay(ms))</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ def all_completed(self):</span><br><span style="color: hsl(120, 100%, 40%);">+ return self._outstanding == 0</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ def wait_for_test(self, loop, deadline):</span><br><span style="color: hsl(120, 100%, 40%);">+ """Waits up to the absolute deadline for the test to complete."""</span><br><span style="color: hsl(120, 100%, 40%);">+ while not self.all_completed():</span><br><span style="color: hsl(120, 100%, 40%);">+ now_time = time.clock_gettime(time.CLOCK_MONOTONIC)</span><br><span style="color: hsl(120, 100%, 40%);">+ sleep_time = deadline - now_time</span><br><span style="color: hsl(120, 100%, 40%);">+ if sleep_time < 0:</span><br><span style="color: hsl(120, 100%, 40%);">+ break</span><br><span style="color: hsl(120, 100%, 40%);">+ loop.schedule_timeout(sleep_time)</span><br><span style="color: hsl(120, 100%, 40%);">+ loop.select()</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ def find_min_max(self, results):</span><br><span style="color: hsl(120, 100%, 40%);">+ min_value = max_value = None</span><br><span style="color: hsl(120, 100%, 40%);">+ for result in results:</span><br><span style="color: hsl(120, 100%, 40%);">+ if min_value is None or lu_delay(result) < min_value:</span><br><span style="color: hsl(120, 100%, 40%);">+ min_value = lu_delay(result)</span><br><span style="color: hsl(120, 100%, 40%);">+ if max_value is None or lu_delay(result) > max_value:</span><br><span style="color: hsl(120, 100%, 40%);">+ max_value = lu_delay(result)</span><br><span style="color: hsl(120, 100%, 40%);">+ return min_value, max_value</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ def get_result_values(self):</span><br><span style="color: hsl(120, 100%, 40%);">+ """</span><br><span style="color: hsl(120, 100%, 40%);">+ Returns the raw result values of the test run in any order.</span><br><span style="color: hsl(120, 100%, 40%);">+ """</span><br><span style="color: hsl(120, 100%, 40%);">+ return self._results.values()</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ def get_stats(self):</span><br><span style="color: hsl(120, 100%, 40%);">+ """</span><br><span style="color: hsl(120, 100%, 40%);">+ Returns a statistical summary of the test.</span><br><span style="color: hsl(120, 100%, 40%);">+ """</span><br><span style="color: hsl(120, 100%, 40%);">+ attempted = self._num_subscribers</span><br><span style="color: hsl(120, 100%, 40%);">+ completed = attempted - self._outstanding</span><br><span style="color: hsl(120, 100%, 40%);">+ min_latency, max_latency = self.find_min_max(filter(lambda x: has_lu_time(x), self._results.values()))</span><br><span style="color: hsl(120, 100%, 40%);">+ return LUStats(attempted, completed, min_latency, max_latency)</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ def print_stats(self):</span><br><span style="color: hsl(120, 100%, 40%);">+ stats = self.get_stats()</span><br><span style="color: hsl(120, 100%, 40%);">+ all_completed = stats.num_attempted == stats.num_completed</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ self.log("Tests done", all_completed=all_completed,</span><br><span style="color: hsl(120, 100%, 40%);">+ min=stats.min_latency, max=stats.max_latency)</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ def lus_less_than(self, acceptable_delay):</span><br><span style="color: hsl(120, 100%, 40%);">+ """</span><br><span style="color: hsl(120, 100%, 40%);">+ Returns LUs that completed within the acceptable delay.</span><br><span style="color: hsl(120, 100%, 40%);">+ """</span><br><span style="color: hsl(120, 100%, 40%);">+ res = []</span><br><span style="color: hsl(120, 100%, 40%);">+ for result in self._results.values():</span><br><span style="color: hsl(120, 100%, 40%);">+ if not has_lu_time(result):</span><br><span style="color: hsl(120, 100%, 40%);">+ continue</span><br><span style="color: hsl(120, 100%, 40%);">+ if timedelta(seconds=lu_delay(result)) >= acceptable_delay:</span><br><span style="color: hsl(120, 100%, 40%);">+ continue</span><br><span style="color: hsl(120, 100%, 40%);">+ res.append(result)</span><br><span style="color: hsl(120, 100%, 40%);">+ return res</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+class MobileTestStarter(log.Origin):</span><br><span> """</span><br><span> A test to launch a configurable amount of MS and make them</span><br><span> execute a Location Updating Procedure.</span><br><span>@@ -70,22 +150,23 @@</span><br><span> TEMPLATE_CFG = "osmo-mobile.cfg"</span><br><span> </span><br><span> def __init__(self, name, options, cdf_function,</span><br><span style="color: hsl(0, 100%, 40%);">- event_server, tmp_dir, suite_run=None):</span><br><span style="color: hsl(120, 100%, 40%);">+ event_server, tmp_dir, results, suite_run=None):</span><br><span> super().__init__(log.C_RUN, name)</span><br><span> self._binary_options = options</span><br><span> self._cdf = cdf_function</span><br><span> self._suite_run = suite_run</span><br><span> self._tmp_dir = tmp_dir</span><br><span style="color: hsl(120, 100%, 40%);">+ self._event_server = event_server</span><br><span style="color: hsl(120, 100%, 40%);">+ self._results = results</span><br><span> self._unstarted = []</span><br><span> self._mobiles = []</span><br><span> self._phys = []</span><br><span style="color: hsl(0, 100%, 40%);">- self._results = {}</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">- self._event_server = event_server</span><br><span style="color: hsl(0, 100%, 40%);">- self._event_server.register(self.handle_msg)</span><br><span> self._started = []</span><br><span> self._subscribers = []</span><br><span> </span><br><span style="color: hsl(120, 100%, 40%);">+ self._event_server.register(self.handle_msg)</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span> def subscriber_add(self, subscriber):</span><br><span> """</span><br><span> Adds a subscriber to the list of subscribers.</span><br><span>@@ -179,28 +260,31 @@</span><br><span> </span><br><span> return current_time + step_size, sleep_time</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">- def run_test(self, loop, test_duration):</span><br><span style="color: hsl(120, 100%, 40%);">+ def start_all(self, loop, test_duration):</span><br><span style="color: hsl(120, 100%, 40%);">+ """</span><br><span style="color: hsl(120, 100%, 40%);">+ Starts all processes according to the schedule set by the CDF.</span><br><span style="color: hsl(120, 100%, 40%);">+ """</span><br><span> self.prepare(loop)</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">- to_complete_time = self._start_time + test_duration.total_seconds()</span><br><span style="color: hsl(120, 100%, 40%);">+ self._to_complete_time = self._start_time + test_duration.total_seconds()</span><br><span> tick_time = self._start_time</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">- while not self.all_completed():</span><br><span style="color: hsl(120, 100%, 40%);">+ while len(self._unstarted) > 0:</span><br><span> tick_time, sleep_time = self.step_once(loop, tick_time)</span><br><span> now_time = time.clock_gettime(time.CLOCK_MONOTONIC)</span><br><span> if sleep_time is None:</span><br><span style="color: hsl(0, 100%, 40%);">- sleep_time = to_complete_time - now_time</span><br><span style="color: hsl(120, 100%, 40%);">+ sleep_time = self._to_complete_time - now_time</span><br><span> if sleep_time < 0:</span><br><span> break</span><br><span> loop.schedule_timeout(sleep_time)</span><br><span> loop.select()</span><br><span style="color: hsl(120, 100%, 40%);">+ return self._to_complete_time</span><br><span> </span><br><span> def stop_all(self):</span><br><span> for launcher in self._started:</span><br><span> launcher.terminate()</span><br><span> </span><br><span> def handle_msg(self, _data, addr, time):</span><br><span style="color: hsl(0, 100%, 40%);">- import json</span><br><span> data = json.loads(_data.decode())</span><br><span> </span><br><span> if data['type'] == 'register':</span><br><span>@@ -208,61 +292,3 @@</span><br><span> ms.set_start_time(time)</span><br><span> launch_delay = ms.start_time() - ms.launch_time()</span><br><span> self.log("MS start registered ", ms=ms, at=time, delay=launch_delay)</span><br><span style="color: hsl(0, 100%, 40%);">- elif data['type'] == 'event':</span><br><span style="color: hsl(0, 100%, 40%);">- if data['data']['lu_done'] == 1:</span><br><span style="color: hsl(0, 100%, 40%);">- ms = self._results[data['ms']]</span><br><span style="color: hsl(0, 100%, 40%);">- if not has_lu_time(ms):</span><br><span style="color: hsl(0, 100%, 40%);">- self._outstanding = self._outstanding - 1</span><br><span style="color: hsl(0, 100%, 40%);">- set_lu_time(ms, time)</span><br><span style="color: hsl(0, 100%, 40%);">- self.log("MS performed LU ", ms=ms, at=time, lu_delay=lu_delay(ms))</span><br><span style="color: hsl(0, 100%, 40%);">- else:</span><br><span style="color: hsl(0, 100%, 40%);">- print(time, data)</span><br><span style="color: hsl(0, 100%, 40%);">- raise Exception("Unknown event type..:" + _data.decode())</span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span style="color: hsl(0, 100%, 40%);">- def all_completed(self):</span><br><span style="color: hsl(0, 100%, 40%);">- return self._outstanding == 0</span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span style="color: hsl(0, 100%, 40%);">- def find_min_max(self, results):</span><br><span style="color: hsl(0, 100%, 40%);">- min_value = max_value = None</span><br><span style="color: hsl(0, 100%, 40%);">- for result in results:</span><br><span style="color: hsl(0, 100%, 40%);">- if min_value is None or lu_delay(result) < min_value:</span><br><span style="color: hsl(0, 100%, 40%);">- min_value = lu_delay(result)</span><br><span style="color: hsl(0, 100%, 40%);">- if max_value is None or lu_delay(result) > max_value:</span><br><span style="color: hsl(0, 100%, 40%);">- max_value = lu_delay(result)</span><br><span style="color: hsl(0, 100%, 40%);">- return min_value, max_value</span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span style="color: hsl(0, 100%, 40%);">- def get_result_values(self):</span><br><span style="color: hsl(0, 100%, 40%);">- """</span><br><span style="color: hsl(0, 100%, 40%);">- Returns the raw result values of the test run in any order.</span><br><span style="color: hsl(0, 100%, 40%);">- """</span><br><span style="color: hsl(0, 100%, 40%);">- return self._results.values()</span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span style="color: hsl(0, 100%, 40%);">- def get_stats(self):</span><br><span style="color: hsl(0, 100%, 40%);">- """</span><br><span style="color: hsl(0, 100%, 40%);">- Returns a statistical summary of the test.</span><br><span style="color: hsl(0, 100%, 40%);">- """</span><br><span style="color: hsl(0, 100%, 40%);">- attempted = len(self._subscribers)</span><br><span style="color: hsl(0, 100%, 40%);">- completed = attempted - self._outstanding</span><br><span style="color: hsl(0, 100%, 40%);">- min_latency, max_latency = self.find_min_max(filter(lambda x: has_lu_time(x), self._results.values()))</span><br><span style="color: hsl(0, 100%, 40%);">- return LUStats(attempted, completed, min_latency, max_latency)</span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span style="color: hsl(0, 100%, 40%);">- def print_stats(self):</span><br><span style="color: hsl(0, 100%, 40%);">- stats = self.get_stats()</span><br><span style="color: hsl(0, 100%, 40%);">- all_completed = stats.num_attempted == stats.num_completed</span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span style="color: hsl(0, 100%, 40%);">- self.log("Tests done", all_completed=all_completed,</span><br><span style="color: hsl(0, 100%, 40%);">- min=stats.min_latency, max=stats.max_latency)</span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span style="color: hsl(0, 100%, 40%);">- def lus_less_than(self, acceptable_delay):</span><br><span style="color: hsl(0, 100%, 40%);">- """</span><br><span style="color: hsl(0, 100%, 40%);">- Returns LUs that completed within the acceptable delay.</span><br><span style="color: hsl(0, 100%, 40%);">- """</span><br><span style="color: hsl(0, 100%, 40%);">- res = []</span><br><span style="color: hsl(0, 100%, 40%);">- for result in self._results.values():</span><br><span style="color: hsl(0, 100%, 40%);">- if not has_lu_time(result):</span><br><span style="color: hsl(0, 100%, 40%);">- continue</span><br><span style="color: hsl(0, 100%, 40%);">- if timedelta(seconds=lu_delay(result)) >= acceptable_delay:</span><br><span style="color: hsl(0, 100%, 40%);">- continue</span><br><span style="color: hsl(0, 100%, 40%);">- res.append(result)</span><br><span style="color: hsl(0, 100%, 40%);">- return res</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/13823">change 13823</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/13823"/><meta itemprop="name" content="View Change"/></div></div>
<div style="display:none"> Gerrit-Project: osmo-gsm-tester </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: merged </div>
<div style="display:none"> Gerrit-Change-Id: Ie15f5123775d11dd44243b2741d047ed93f318f9 </div>
<div style="display:none"> Gerrit-Change-Number: 13823 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Holger Freyther <holger@freyther.de> </div>
<div style="display:none"> Gerrit-Reviewer: Harald Welte <laforge@gnumonks.org> </div>
<div style="display:none"> Gerrit-Reviewer: Holger Freyther <holger@freyther.de> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder (1000002) </div>
<div style="display:none"> Gerrit-Reviewer: Pau Espin Pedrol <pespin@sysmocom.de> </div>