<p><a href="https://gerrit.osmocom.org/13811">View Change</a></p><p>1 comment:</p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0;"><p><a href="https://gerrit.osmocom.org/#/c/13811/1/src/gprs/gprs_llc.c">File src/gprs/gprs_llc.c:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.osmocom.org/#/c/13811/1/src/gprs/gprs_llc.c@267">Patch Set #1, Line 267:</a> <code style="font-family:monospace,monospace">                                  xid_field_response = gprs_llc_dup_xid_field(lle->llme, xid_field);</code></p><p><blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;">If you "echo" something backs, it means you accept the XID. […]</blockquote></p><p style="white-space: pre-wrap; word-wrap: break-word;">I understand that the "echo" is a confirmation.</p><p style="white-space: pre-wrap; word-wrap: break-word;">What I was referring to here is the need to call gprs_lls_cup_xid_field() but now I'm guessing that <br>sndcp_sn_xid_ind() was "populating" the talloc_zero'd struct? or something like that?</p><p style="white-space: pre-wrap; word-wrap: break-word;">My lack of C and pointer foo strikes again...</p></li></ul></li></ul><p>To view, visit <a href="https://gerrit.osmocom.org/13811">change 13811</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/13811"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-sgsn </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: comment </div>
<div style="display:none"> Gerrit-Change-Id: Ibd75f7b943c84ed7264481fa2e4bc3cb2f6745d4 </div>
<div style="display:none"> Gerrit-Change-Number: 13811 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Keith Whyte <keith@rhizomatica.org> </div>
<div style="display:none"> Gerrit-Reviewer: Harald Welte <laforge@gnumonks.org> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder (1000002) </div>
<div style="display:none"> Gerrit-Reviewer: Keith Whyte <keith@rhizomatica.org> </div>
<div style="display:none"> Gerrit-Reviewer: lynxis lazus <lynxis@fe80.eu> </div>
<div style="display:none"> Gerrit-Comment-Date: Tue, 30 Apr 2019 06:59:51 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>
<div style="display:none"> Gerrit-HasLabels: No </div>