<p>Neels Hofmeyr has uploaded this change for <strong>review</strong>.</p><p><a href="https://gerrit.osmocom.org/13817">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">osmo_gsup_decode(): properly check IMSI, avoid deprecation<br><br>In osmo_gsup_decode(), call gsm48_decode_bcd_number2() to avoid deprecation<br>warning, and also actually check the return value to detect invalid IMSI IEs.<br><br>Change-Id: Iaded84d91baad5386c8f353c283b6b9e40a43b05<br>---<br>M src/gsm/gsup.c<br>1 file changed, 5 insertions(+), 3 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/17/13817/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/gsm/gsup.c b/src/gsm/gsup.c</span><br><span>index a3d9eef..2e6690e 100644</span><br><span>--- a/src/gsm/gsup.c</span><br><span>+++ b/src/gsm/gsup.c</span><br><span>@@ -332,9 +332,11 @@</span><br><span>   * before the value part already contains this length so we can use it</span><br><span>        * here.</span><br><span>      */</span><br><span style="color: hsl(0, 100%, 40%);">-     OSMO_ASSERT(value[-1] == value_len);</span><br><span style="color: hsl(0, 100%, 40%);">-    gsm48_decode_bcd_number(gsup_msg->imsi, sizeof(gsup_msg->imsi),</span><br><span style="color: hsl(0, 100%, 40%);">-                           value - 1, 0);</span><br><span style="color: hsl(120, 100%, 40%);">+        if (gsm48_decode_bcd_number2(gsup_msg->imsi, sizeof(gsup_msg->imsi),</span><br><span style="color: hsl(120, 100%, 40%);">+                                 value - 1, value_len + 1, 0)) {</span><br><span style="color: hsl(120, 100%, 40%);">+          LOGP(DLGSUP, LOGL_ERROR, "Cannot decode IMSI\n");</span><br><span style="color: hsl(120, 100%, 40%);">+           return -GMM_CAUSE_INV_MAND_INFO;</span><br><span style="color: hsl(120, 100%, 40%);">+      }</span><br><span> </span><br><span>        /* specific parts */</span><br><span>         while (data_len > 0) {</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/13817">change 13817</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/13817"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: libosmocore </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>
<div style="display:none"> Gerrit-Change-Id: Iaded84d91baad5386c8f353c283b6b9e40a43b05 </div>
<div style="display:none"> Gerrit-Change-Number: 13817 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Neels Hofmeyr <nhofmeyr@sysmocom.de> </div>