<p>Patch set 3:<span style="border-radius: 3px; display: inline-block; margin: 0 2px; padding: 4px;background-color: #ffd4d4;">Code-Review -1</span></p><p><a href="https://gerrit.osmocom.org/13811">View Change</a></p><p>2 comments:</p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0;"><p><a href="https://gerrit.osmocom.org/#/c/13811/3/src/gprs/gprs_sndcp.c">File src/gprs/gprs_sndcp.c:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.osmocom.org/#/c/13811/3/src/gprs/gprs_sndcp.c@1125">Patch Set #3, Line 1125:</a> <code style="font-family:monospace,monospace">               xid_field_response = gprs_llc_dup_xid_field(lle->llme, xid_field_indication);</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">this doesn't work as I don't know how to get this value back to caller.</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.osmocom.org/#/c/13811/3/src/gprs/gprs_sndcp.c@1126">Patch Set #3, Line 1126:</a> <code style="font-family:monospace,monospace">            // xid_field_response->list = gprs_llc_copy_xid(lle->llme, &xid_field_indication->list);</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">this would seem to my mind to be going in the right direction, but it doesn't compile, because I don't know C.<br>@lynxis, can you help me out?</p></li></ul></li></ul><p>To view, visit <a href="https://gerrit.osmocom.org/13811">change 13811</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/13811"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-sgsn </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: comment </div>
<div style="display:none"> Gerrit-Change-Id: Ibd75f7b943c84ed7264481fa2e4bc3cb2f6745d4 </div>
<div style="display:none"> Gerrit-Change-Number: 13811 </div>
<div style="display:none"> Gerrit-PatchSet: 3 </div>
<div style="display:none"> Gerrit-Owner: Keith Whyte <keith@rhizomatica.org> </div>
<div style="display:none"> Gerrit-Reviewer: Harald Welte <laforge@gnumonks.org> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder (1000002) </div>
<div style="display:none"> Gerrit-Reviewer: Keith Whyte <keith@rhizomatica.org> </div>
<div style="display:none"> Gerrit-Reviewer: lynxis lazus <lynxis@fe80.eu> </div>
<div style="display:none"> Gerrit-Comment-Date: Tue, 30 Apr 2019 09:51:14 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>
<div style="display:none"> Gerrit-HasLabels: Yes </div>