<p>Keith Whyte has uploaded this change for <strong>review</strong>.</p><p><a href="https://gerrit.osmocom.org/13811">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">Echo XID-Field of Type L3_PAR even when zero length<br><br>After Activate PDP Context request, Motorola KRZR<br>sends a zero length XID-Field of Type L3 Parameters<br><br>If this is not echoed back, the phone will send<br>Deactivate PDP Context request with SM Cause:<br>LLC or SNDCP failure(A/Gb only) (25)<br><br>Change-Id: Ibd75f7b943c84ed7264481fa2e4bc3cb2f6745d4<br>---<br>M src/gprs/gprs_llc.c<br>M src/gprs/gprs_sndcp.c<br>2 files changed, 15 insertions(+), 4 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://gerrit.osmocom.org:29418/osmo-sgsn refs/changes/11/13811/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/gprs/gprs_llc.c b/src/gprs/gprs_llc.c</span><br><span>index acf4b54..02455b1 100644</span><br><span>--- a/src/gprs/gprs_llc.c</span><br><span>+++ b/src/gprs/gprs_llc.c</span><br><span>@@ -256,11 +256,20 @@</span><br><span>                                            struct gprs_llc_xid_field);</span><br><span>                          rc = sndcp_sn_xid_ind(xid_field,</span><br><span>                                                   xid_field_response, lle);</span><br><span style="color: hsl(0, 100%, 40%);">-                         if (rc == 0)</span><br><span style="color: hsl(0, 100%, 40%);">-                                    llist_add(&xid_field_response->list,</span><br><span style="color: hsl(0, 100%, 40%);">-                                               xid_fields_response);</span><br><span style="color: hsl(0, 100%, 40%);">-                         else</span><br><span style="color: hsl(120, 100%, 40%);">+                          if (rc == 0) {</span><br><span style="color: hsl(120, 100%, 40%);">+                                        LOGP(DLLC, LOGL_NOTICE,</span><br><span style="color: hsl(120, 100%, 40%);">+                                            "Echoing XID-Field: XID: type %s, data_len=%d, data=%s\n",</span><br><span style="color: hsl(120, 100%, 40%);">+                                          get_value_string(gprs_llc_xid_type_names,</span><br><span style="color: hsl(120, 100%, 40%);">+                                                              xid_field->type),</span><br><span style="color: hsl(120, 100%, 40%);">+                                         xid_field->data_len,</span><br><span style="color: hsl(120, 100%, 40%);">+                                       osmo_hexdump_nospc(xid_field->data,</span><br><span style="color: hsl(120, 100%, 40%);">+                                                           xid_field->data_len));</span><br><span style="color: hsl(120, 100%, 40%);">+                                     xid_field_response = gprs_llc_dup_xid_field(lle->llme, xid_field);</span><br><span style="color: hsl(120, 100%, 40%);">+                                 llist_add(&xid_field_response->list, xid_fields_response);</span><br><span style="color: hsl(120, 100%, 40%);">+                             }</span><br><span style="color: hsl(120, 100%, 40%);">+                             else {</span><br><span>                                       talloc_free(xid_field_response);</span><br><span style="color: hsl(120, 100%, 40%);">+                              }</span><br><span>                    }</span><br><span>            }</span><br><span> </span><br><span>diff --git a/src/gprs/gprs_sndcp.c b/src/gprs/gprs_sndcp.c</span><br><span>index 23d1e9a..33d8cf6 100644</span><br><span>--- a/src/gprs/gprs_sndcp.c</span><br><span>+++ b/src/gprs/gprs_sndcp.c</span><br><span>@@ -1125,6 +1125,8 @@</span><br><span>                                          xid_field_indication->data,</span><br><span>                                       xid_field_indication->data_len,</span><br><span>                                           NULL);</span><br><span style="color: hsl(120, 100%, 40%);">+     if (comp_fields == NULL)</span><br><span style="color: hsl(120, 100%, 40%);">+              return 0;</span><br><span>    if (!comp_fields)</span><br><span>            return -EINVAL;</span><br><span> </span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/13811">change 13811</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/13811"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-sgsn </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>
<div style="display:none"> Gerrit-Change-Id: Ibd75f7b943c84ed7264481fa2e4bc3cb2f6745d4 </div>
<div style="display:none"> Gerrit-Change-Number: 13811 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Keith Whyte <keith@rhizomatica.org> </div>