<p>Pau Espin Pedrol <strong>merged</strong> this change.</p><p><a href="https://gerrit.osmocom.org/13799">View Change</a></p><div style="white-space:pre-wrap">Approvals:
  Jenkins Builder: Verified
  Harald Welte: Looks good to me, approved

</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">gprs_sndcp_comp_free: Replace ifelse with switch and better handling of error<br><br>gprs_sndcp_dcomp_term asserts if compclass is not<br>SNDCP_XID_DATA_COMPRESSION, so this way by checking in the caller too we<br>easily now if the unexpected value is in compclass or in algo.dcomp.<br><br>Change-Id: I4600e6a137f42f20fdf69637e4a9048b265c1748<br>---<br>M src/gprs/gprs_sndcp_comp.c<br>1 file changed, 9 insertions(+), 2 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/gprs/gprs_sndcp_comp.c b/src/gprs/gprs_sndcp_comp.c</span><br><span>index 0b4c67c..c71cc89 100644</span><br><span>--- a/src/gprs/gprs_sndcp_comp.c</span><br><span>+++ b/src/gprs/gprs_sndcp_comp.c</span><br><span>@@ -160,16 +160,23 @@</span><br><span> </span><br><span>     llist_for_each_entry(comp_entity, comp_entities, list) {</span><br><span>             /* Free compression entity */</span><br><span style="color: hsl(0, 100%, 40%);">-           if (comp_entity->compclass == SNDCP_XID_PROTOCOL_COMPRESSION) {</span><br><span style="color: hsl(120, 100%, 40%);">+            switch (comp_entity->compclass) {</span><br><span style="color: hsl(120, 100%, 40%);">+          case SNDCP_XID_PROTOCOL_COMPRESSION:</span><br><span>                         LOGP(DSNDCP, LOGL_INFO,</span><br><span>                           "Deleting header compression entity %d ...\n",</span><br><span>                             comp_entity->entity);</span><br><span>                        gprs_sndcp_pcomp_term(comp_entity);</span><br><span style="color: hsl(0, 100%, 40%);">-             } else {</span><br><span style="color: hsl(120, 100%, 40%);">+                      break;</span><br><span style="color: hsl(120, 100%, 40%);">+                case SNDCP_XID_DATA_COMPRESSION:</span><br><span>                     LOGP(DSNDCP, LOGL_INFO,</span><br><span>                           "Deleting data compression entity %d ...\n",</span><br><span>                       comp_entity->entity);</span><br><span>                        gprs_sndcp_dcomp_term(comp_entity);</span><br><span style="color: hsl(120, 100%, 40%);">+                   break;</span><br><span style="color: hsl(120, 100%, 40%);">+                default:</span><br><span style="color: hsl(120, 100%, 40%);">+                      LOGP(DSNDCP, LOGL_INFO,</span><br><span style="color: hsl(120, 100%, 40%);">+                            "Invalid compression class %d!\n", comp_entity->compclass);</span><br><span style="color: hsl(120, 100%, 40%);">+                 OSMO_ASSERT(false);</span><br><span>          }</span><br><span>    }</span><br><span> </span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/13799">change 13799</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/13799"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-sgsn </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: merged </div>
<div style="display:none"> Gerrit-Change-Id: I4600e6a137f42f20fdf69637e4a9048b265c1748 </div>
<div style="display:none"> Gerrit-Change-Number: 13799 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Pau Espin Pedrol <pespin@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: Harald Welte <laforge@gnumonks.org> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder (1000002) </div>
<div style="display:none"> Gerrit-Reviewer: Pau Espin Pedrol <pespin@sysmocom.de> </div>