<p>Pau Espin Pedrol <strong>merged</strong> this change.</p><p><a href="https://gerrit.osmocom.org/13782">View Change</a></p><div style="white-space:pre-wrap">Approvals:
  Jenkins Builder: Verified
  Harald Welte: Looks good to me, approved

</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">lms: flush_recv: alloc buf on stack instead of heap<br><br>No need to use the heap here since buffer is only used as a temporary<br>trash. Using the stack is quicker.<br><br>Change-Id: Iede8dc0903ee3865a52c8e2fd811bcde444fee33<br>---<br>M Transceiver52M/device/lms/LMSDevice.cpp<br>1 file changed, 1 insertion(+), 3 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/Transceiver52M/device/lms/LMSDevice.cpp b/Transceiver52M/device/lms/LMSDevice.cpp</span><br><span>index 05904e8..064d742 100644</span><br><span>--- a/Transceiver52M/device/lms/LMSDevice.cpp</span><br><span>+++ b/Transceiver52M/device/lms/LMSDevice.cpp</span><br><span>@@ -450,7 +450,7 @@</span><br><span> {</span><br><span>        #define CHUNK 625</span><br><span>    int len = CHUNK * tx_sps;</span><br><span style="color: hsl(0, 100%, 40%);">-       short *buffer = new short[len * 2];</span><br><span style="color: hsl(120, 100%, 40%);">+   short *buffer = (short*) alloca(sizeof(short) * len * 2);</span><br><span>    int rc;</span><br><span>      lms_stream_meta_t rx_metadata = {};</span><br><span>  rx_metadata.flushPartialPacket = false;</span><br><span>@@ -463,7 +463,6 @@</span><br><span>                LOGC(DDEV, DEBUG) << "Flush: Recv buffer of len " << rc << " at " << std::hex << rx_metadata.timestamp;</span><br><span>            if (rc != len) {</span><br><span>                     LOGC(DDEV, ALERT) << "LMS: Device receive timed out";</span><br><span style="color: hsl(0, 100%, 40%);">-                   delete[] buffer;</span><br><span>                     return false;</span><br><span>                }</span><br><span> </span><br><span>@@ -471,7 +470,6 @@</span><br><span>  }</span><br><span> </span><br><span>        LOGC(DDEV, INFO) << "Initial timestamp " << ts_initial << std::endl;</span><br><span style="color: hsl(0, 100%, 40%);">-        delete[] buffer;</span><br><span>     return true;</span><br><span> }</span><br><span> </span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/13782">change 13782</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/13782"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-trx </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: merged </div>
<div style="display:none"> Gerrit-Change-Id: Iede8dc0903ee3865a52c8e2fd811bcde444fee33 </div>
<div style="display:none"> Gerrit-Change-Number: 13782 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Pau Espin Pedrol <pespin@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: Harald Welte <laforge@gnumonks.org> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder (1000002) </div>
<div style="display:none"> Gerrit-Reviewer: Pau Espin Pedrol <pespin@sysmocom.de> </div>
<div style="display:none"> Gerrit-CC: Max <suraev@alumni.ntnu.no> </div>