<p>Vadim Yanitskiy <strong>merged</strong> this change.</p><p><a href="https://gerrit.osmocom.org/13740">View Change</a></p><div style="white-space:pre-wrap">Approvals:
  Jenkins Builder: Verified
  Pau Espin Pedrol: Looks good to me, but someone else must approve
  Harald Welte: Looks good to me, approved

</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">common/rsl.c: fix size argument in memcmp() call<br><br>Found using clang-8:<br><br>  rsl.c:1607:93: warning: size argument in 'memcmp' call<br>                          is a comparison [-Wmemsize-comparison]<br>  rsl.c:1607:7: note: did you mean to compare the result of 'memcmp' instead?<br><br>It looks more logical to compare the result of memcmp() against<br>zero instead of passing 'sizeof(sysinfo_buf_t) != 0' as size.<br><br>Change-Id: Ia8b95b017dbbfeb058d479fbaaf4861930569bb5<br>---<br>M src/common/rsl.c<br>1 file changed, 1 insertion(+), 1 deletion(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/common/rsl.c b/src/common/rsl.c</span><br><span>index 5287201..8f5d689 100644</span><br><span>--- a/src/common/rsl.c</span><br><span>+++ b/src/common/rsl.c</span><br><span>@@ -1604,7 +1604,7 @@</span><br><span>                uint16_t len = TLVP_LEN(&tp, RSL_IE_L3_INFO);</span><br><span> </span><br><span>                lapdm_ui_prefix_lchan(lchan, TLVP_VAL(&tp, RSL_IE_L3_INFO), osmo_si, len);</span><br><span style="color: hsl(0, 100%, 40%);">-          if (memcmp(GSM_BTS_SI(bts, osmo_si), TLVP_VAL(&tp, RSL_IE_L3_INFO), sizeof(sysinfo_buf_t) != 0))</span><br><span style="color: hsl(120, 100%, 40%);">+          if (memcmp(GSM_BTS_SI(bts, osmo_si), TLVP_VAL(&tp, RSL_IE_L3_INFO), sizeof(sysinfo_buf_t)) != 0)</span><br><span>                         lchan->si.overridden |= (1 << osmo_si);</span><br><span>             else</span><br><span>                         lchan->si.overridden &= ~(1 << osmo_si);</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/13740">change 13740</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/13740"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-bts </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: merged </div>
<div style="display:none"> Gerrit-Change-Id: Ia8b95b017dbbfeb058d479fbaaf4861930569bb5 </div>
<div style="display:none"> Gerrit-Change-Number: 13740 </div>
<div style="display:none"> Gerrit-PatchSet: 2 </div>
<div style="display:none"> Gerrit-Owner: Vadim Yanitskiy <axilirator@gmail.com> </div>
<div style="display:none"> Gerrit-Reviewer: Harald Welte <laforge@gnumonks.org> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder (1000002) </div>
<div style="display:none"> Gerrit-Reviewer: Pau Espin Pedrol <pespin@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: Vadim Yanitskiy <axilirator@gmail.com> </div>