<p>lynxis lazus <strong>merged</strong> this change.</p><p><a href="https://gerrit.osmocom.org/13654">View Change</a></p><div style="white-space:pre-wrap">Approvals:
  Mykola Shchetinin: Looks good to me, approved
  Jenkins Builder: Verified

</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">gprs_gmm: reintroduce calling gsm48_gmm_authorize when not handling GMM Attach Requests<br><br>A security command is part of multiple procedures to ensure<br>integrity (optional also encryption) between MS and RNC.<br>It should be used for all Iu connections once.<br>With the rewrite of the GMM Attach FSM the use of the security command<br>procedure was broken for all procedures e.g. Service Request except GMM<br>Attach Request.<br><br>Relates: OS#3920<br>Change-Id: I50e8e316f06ae1a6171a6b07e4e2f0761322b779<br>---<br>M src/gprs/gprs_gmm.c<br>1 file changed, 6 insertions(+), 1 deletion(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/gprs/gprs_gmm.c b/src/gprs/gprs_gmm.c</span><br><span>index b0c5902..358bff9 100644</span><br><span>--- a/src/gprs/gprs_gmm.c</span><br><span>+++ b/src/gprs/gprs_gmm.c</span><br><span>@@ -205,7 +205,12 @@</span><br><span>            REQUIRE_MM</span><br><span>           /* Continue authentication here */</span><br><span>           mm->iu.ue_ctx->integrity_active = 1;</span><br><span style="color: hsl(0, 100%, 40%);">-              osmo_fsm_inst_dispatch(mm->gmm_att_req.fsm, E_IU_SECURITY_CMD_COMPLETE, NULL);</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+           /* FIXME: remove gmm_authorize */</span><br><span style="color: hsl(120, 100%, 40%);">+             if (mm->pending_req != GSM48_MT_GMM_ATTACH_REQ)</span><br><span style="color: hsl(120, 100%, 40%);">+                    gsm48_gmm_authorize(mm);</span><br><span style="color: hsl(120, 100%, 40%);">+              else</span><br><span style="color: hsl(120, 100%, 40%);">+                  osmo_fsm_inst_dispatch(mm->gmm_att_req.fsm, E_IU_SECURITY_CMD_COMPLETE, NULL);</span><br><span>            break;</span><br><span>       default:</span><br><span>             LOGP(DRANAP, LOGL_NOTICE, "Unknown event received: %i\n", type);</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/13654">change 13654</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/13654"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-sgsn </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: merged </div>
<div style="display:none"> Gerrit-Change-Id: I50e8e316f06ae1a6171a6b07e4e2f0761322b779 </div>
<div style="display:none"> Gerrit-Change-Number: 13654 </div>
<div style="display:none"> Gerrit-PatchSet: 2 </div>
<div style="display:none"> Gerrit-Owner: lynxis lazus <lynxis@fe80.eu> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder (1000002) </div>
<div style="display:none"> Gerrit-Reviewer: Mykola Shchetinin <mykola@pentonet.com> </div>
<div style="display:none"> Gerrit-Reviewer: lynxis lazus <lynxis@fe80.eu> </div>
<div style="display:none"> Gerrit-CC: Pau Espin Pedrol <pespin@sysmocom.de> </div>