<p>Harald Welte <strong>merged</strong> this change.</p><p><a href="https://gerrit.osmocom.org/13727">View Change</a></p><div style="white-space:pre-wrap">Approvals:
  Jenkins Builder: Verified
  Harald Welte: Looks good to me, approved

</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">BSC_ConnectionHandler: Define SDP template for CN-side CRCX<br><br>Change-Id: I90546249c41de8f99ce4a558e76cb46597413518<br>---<br>M msc/BSC_ConnectionHandler.ttcn<br>1 file changed, 11 insertions(+), 14 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/msc/BSC_ConnectionHandler.ttcn b/msc/BSC_ConnectionHandler.ttcn</span><br><span>index 8e5c5f2..0b2344f 100644</span><br><span>--- a/msc/BSC_ConnectionHandler.ttcn</span><br><span>+++ b/msc/BSC_ConnectionHandler.ttcn</span><br><span>@@ -469,6 +469,15 @@</span><br><span>                                   hex2str(cpars.called_party), hex2str(g_pars.imsi)));</span><br><span> }</span><br><span> </span><br><span style="color: hsl(120, 100%, 40%);">+private template (value) SDP_Message ts_SDP_CRCX_CN(CallParameters cpars) :=</span><br><span style="color: hsl(120, 100%, 40%);">+   ts_SDP(cpars.mgw_rtp_ip_mss, cpars.mgw_rtp_ip_mss,</span><br><span style="color: hsl(120, 100%, 40%);">+            hex2str(cpars.mgcp_call_id), "42",</span><br><span style="color: hsl(120, 100%, 40%);">+          cpars.mgw_rtp_port_mss,</span><br><span style="color: hsl(120, 100%, 40%);">+               { int2str(cpars.rtp_payload_type) },</span><br><span style="color: hsl(120, 100%, 40%);">+          { valueof(ts_SDP_rtpmap(cpars.rtp_payload_type,</span><br><span style="color: hsl(120, 100%, 40%);">+                 cpars.rtp_sdp_format)),</span><br><span style="color: hsl(120, 100%, 40%);">+               valueof(ts_SDP_ptime(20)) });</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span> /* Complete call, begin with a paging response message via BSSAP */</span><br><span> function f_mt_call_complete(inout CallParameters cpars)</span><br><span> runs on BSC_ConnHdlr {</span><br><span>@@ -521,13 +530,7 @@</span><br><span>         interleave {</span><br><span>         /* Second MGCP CRCX (this time for MSS/CN side) */</span><br><span>   [] MGCP.receive(tr_CRCX(cpars.mgcp_ep)) -> value mgcp_cmd {</span><br><span style="color: hsl(0, 100%, 40%);">-          var SDP_Message sdp := valueof(ts_SDP(cpars.mgw_rtp_ip_mss, cpars.mgw_rtp_ip_mss,</span><br><span style="color: hsl(0, 100%, 40%);">-                                                       hex2str(cpars.mgcp_call_id), "42",</span><br><span style="color: hsl(0, 100%, 40%);">-                                                    cpars.mgw_rtp_port_mss,</span><br><span style="color: hsl(0, 100%, 40%);">-                                                 { int2str(cpars.rtp_payload_type) },</span><br><span style="color: hsl(0, 100%, 40%);">-                                                    { valueof(ts_SDP_rtpmap(cpars.rtp_payload_type,</span><br><span style="color: hsl(0, 100%, 40%);">-                                                                         cpars.rtp_sdp_format)),</span><br><span style="color: hsl(0, 100%, 40%);">-                                                   valueof(ts_SDP_ptime(20)) }));</span><br><span style="color: hsl(120, 100%, 40%);">+              var SDP_Message sdp := valueof(ts_SDP_CRCX_CN(cpars));</span><br><span>               MGCP.send(ts_CRCX_ACK(mgcp_cmd.line.trans_id, cpars.mgcp_connection_id_mss, sdp));</span><br><span>           /* MSC acknowledges the MNCC_CREATE to the MNCC handler */</span><br><span>           MNCC.receive(tr_MNCC_RTP_CREATE(cpars.mncc_callref));</span><br><span>@@ -626,13 +629,7 @@</span><br><span>         interleave {</span><br><span>         /* Second MGCP CRCX (this time for MSS/CN side) */</span><br><span>   [] MGCP.receive(tr_CRCX(cpars.mgcp_ep)) -> value mgcp_cmd {</span><br><span style="color: hsl(0, 100%, 40%);">-          var SDP_Message sdp := valueof(ts_SDP(cpars.mgw_rtp_ip_mss, cpars.mgw_rtp_ip_mss,</span><br><span style="color: hsl(0, 100%, 40%);">-                                                       hex2str(cpars.mgcp_call_id), "42",</span><br><span style="color: hsl(0, 100%, 40%);">-                                                    cpars.mgw_rtp_port_mss,</span><br><span style="color: hsl(0, 100%, 40%);">-                                                 { int2str(cpars.rtp_payload_type) },</span><br><span style="color: hsl(0, 100%, 40%);">-                                                    { valueof(ts_SDP_rtpmap(cpars.rtp_payload_type,</span><br><span style="color: hsl(0, 100%, 40%);">-                                                                         cpars.rtp_sdp_format)),</span><br><span style="color: hsl(0, 100%, 40%);">-                                                   valueof(ts_SDP_ptime(20)) }));</span><br><span style="color: hsl(120, 100%, 40%);">+              var SDP_Message sdp := valueof(ts_SDP_CRCX_CN(cpars));</span><br><span>               MGCP.send(ts_CRCX_ACK(mgcp_cmd.line.trans_id, cpars.mgcp_connection_id_mss, sdp));</span><br><span> </span><br><span>               /* Alerting */</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/13727">change 13727</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/13727"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-ttcn3-hacks </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: merged </div>
<div style="display:none"> Gerrit-Change-Id: I90546249c41de8f99ce4a558e76cb46597413518 </div>
<div style="display:none"> Gerrit-Change-Number: 13727 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Harald Welte <laforge@gnumonks.org> </div>
<div style="display:none"> Gerrit-Reviewer: Harald Welte <laforge@gnumonks.org> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder (1000002) </div>