<p>Vadim Yanitskiy has uploaded this change for <strong>review</strong>.</p><p><a href="https://gerrit.osmocom.org/13720">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">Assign random MSISDN to subscribers created on demand<br><br>Change-Id: I475c71f9902950fa7498855a616e1ec231fad6ac<br>---<br>M src/hlr.c<br>1 file changed, 41 insertions(+), 5 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://gerrit.osmocom.org:29418/osmo-hlr refs/changes/20/13720/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/hlr.c b/src/hlr.c</span><br><span>index 7facef7..4fb039e 100644</span><br><span>--- a/src/hlr.c</span><br><span>+++ b/src/hlr.c</span><br><span>@@ -34,6 +34,7 @@</span><br><span> #include <osmocom/ctrl/control_vty.h></span><br><span> #include <osmocom/gsm/apn.h></span><br><span> #include <osmocom/gsm/gsm48_ie.h></span><br><span style="color: hsl(120, 100%, 40%);">+#include <osmocom/gsm/gsm_utils.h></span><br><span> </span><br><span> #include "db.h"</span><br><span> #include "hlr.h"</span><br><span>@@ -148,19 +149,54 @@</span><br><span> }</span><br><span> }</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-static void subscr_create_on_demand(const char *imsi)</span><br><span style="color: hsl(120, 100%, 40%);">+static int subscr_create_on_demand(const char *imsi)</span><br><span> {</span><br><span style="color: hsl(0, 100%, 40%);">- int rc;</span><br><span style="color: hsl(120, 100%, 40%);">+ uint8_t rand_buf[15];</span><br><span style="color: hsl(120, 100%, 40%);">+ char msisdn[15 + 1];</span><br><span style="color: hsl(120, 100%, 40%);">+ int i, rc;</span><br><span> </span><br><span> if (!g_hlr->create_subscr_on_demand)</span><br><span style="color: hsl(0, 100%, 40%);">- return;</span><br><span style="color: hsl(120, 100%, 40%);">+ return -1;</span><br><span> if (db_subscr_exists_by_imsi(g_hlr->dbc, imsi) == 0)</span><br><span style="color: hsl(0, 100%, 40%);">- return;</span><br><span style="color: hsl(120, 100%, 40%);">+ return -1;</span><br><span> </span><br><span> LOGP(DMAIN, LOGL_INFO, "IMSI='%s': Creating subscriber on demand\n", imsi);</span><br><span> rc = db_subscr_create(g_hlr->dbc, imsi, 1, 1); /* Allow both CS and PS domains by default */</span><br><span style="color: hsl(0, 100%, 40%);">- if (rc)</span><br><span style="color: hsl(120, 100%, 40%);">+ if (rc) {</span><br><span> LOGP(DMAIN, LOGL_ERROR, "Failed to create subscriber on demand (rc=%d): IMSI='%s'\n", rc, imsi);</span><br><span style="color: hsl(120, 100%, 40%);">+ return rc;</span><br><span style="color: hsl(120, 100%, 40%);">+ }</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ /* FIXME: this should be optional and configurable! */</span><br><span style="color: hsl(120, 100%, 40%);">+ #define RAND_MSISDN_LEN 6</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ /* Generate a random unique MSISDN */</span><br><span style="color: hsl(120, 100%, 40%);">+ while (1) {</span><br><span style="color: hsl(120, 100%, 40%);">+ rc = osmo_get_rand_id(rand_buf, RAND_MSISDN_LEN);</span><br><span style="color: hsl(120, 100%, 40%);">+ if (rc) /* Keep trying until we get some result */</span><br><span style="color: hsl(120, 100%, 40%);">+ continue;</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ /* Shift 0x00 ... 0xff range to 30 ... 39 (ASCII numbers) */</span><br><span style="color: hsl(120, 100%, 40%);">+ for (i = 0; i < RAND_MSISDN_LEN; i++)</span><br><span style="color: hsl(120, 100%, 40%);">+ msisdn[i] = 48 + (rand_buf[i] % 10);</span><br><span style="color: hsl(120, 100%, 40%);">+ msisdn[i] = '\0';</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ /* Ensure there is subscriber with such MSISDN */</span><br><span style="color: hsl(120, 100%, 40%);">+ if (db_subscr_exists_by_msisdn(g_hlr->dbc, msisdn))</span><br><span style="color: hsl(120, 100%, 40%);">+ break;</span><br><span style="color: hsl(120, 100%, 40%);">+ }</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ /* Update MSISDN of the new (just allocated) subscriber */</span><br><span style="color: hsl(120, 100%, 40%);">+ rc = db_subscr_update_msisdn_by_imsi(g_hlr->dbc, imsi, msisdn);</span><br><span style="color: hsl(120, 100%, 40%);">+ if (rc) {</span><br><span style="color: hsl(120, 100%, 40%);">+ LOGP(DMAIN, LOGL_ERROR, "IMSI='%s': Failed to assign MSISDN='%s' "</span><br><span style="color: hsl(120, 100%, 40%);">+ "(rc=%d)\n", imsi, msisdn, rc);</span><br><span style="color: hsl(120, 100%, 40%);">+ return rc;</span><br><span style="color: hsl(120, 100%, 40%);">+ }</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ LOGP(DMAIN, LOGL_INFO, "IMSI='%s': Successfully assigned MSISDN='%s'\n", imsi, msisdn);</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ return 0;</span><br><span> }</span><br><span> </span><br><span> /***********************************************************************</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/13720">change 13720</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/13720"/><meta itemprop="name" content="View Change"/></div></div>
<div style="display:none"> Gerrit-Project: osmo-hlr </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>
<div style="display:none"> Gerrit-Change-Id: I475c71f9902950fa7498855a616e1ec231fad6ac </div>
<div style="display:none"> Gerrit-Change-Number: 13720 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Vadim Yanitskiy <axilirator@gmail.com> </div>