<p>Vadim Yanitskiy has uploaded this change for <strong>review</strong>.</p><p><a href="https://gerrit.osmocom.org/13713">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">Add subscriber-create-on-demand option<br><br>Related: OS#2542<br>Change-Id: I0c9fe93f5c24b5e9fefb513c4d049fb7ebd47ecd<br>---<br>M src/hlr.c<br>M src/hlr.h<br>M src/hlr_vty.c<br>3 files changed, 36 insertions(+), 0 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://gerrit.osmocom.org:29418/osmo-hlr refs/changes/13/13713/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/hlr.c b/src/hlr.c</span><br><span>index 422a56d..b739e71 100644</span><br><span>--- a/src/hlr.c</span><br><span>+++ b/src/hlr.c</span><br><span>@@ -148,6 +148,18 @@</span><br><span> }</span><br><span> }</span><br><span> </span><br><span style="color: hsl(120, 100%, 40%);">+static void subscr_create_on_demand(const char *imsi) {</span><br><span style="color: hsl(120, 100%, 40%);">+ int rc;</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ if (!g_hlr->create_subscr_on_demand || db_subscr_exists_by_imsi(g_hlr->dbc, imsi) == 0)</span><br><span style="color: hsl(120, 100%, 40%);">+ return;</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ LOGP(DMAIN, LOGL_INFO, "IMSI='%s': Creating subscriber on demand\n", imsi);</span><br><span style="color: hsl(120, 100%, 40%);">+ rc = db_subscr_create(g_hlr->dbc, imsi, 0, 0);</span><br><span style="color: hsl(120, 100%, 40%);">+ if (rc)</span><br><span style="color: hsl(120, 100%, 40%);">+ LOGP(DMAIN, LOGL_ERROR, "Failed to create subscriber on demand (rc=%d): IMSI='%s'\n", rc, imsi);</span><br><span style="color: hsl(120, 100%, 40%);">+}</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span> /***********************************************************************</span><br><span> * Send Auth Info handling</span><br><span> ***********************************************************************/</span><br><span>@@ -161,6 +173,8 @@</span><br><span> struct msgb *msg_out;</span><br><span> int rc;</span><br><span> </span><br><span style="color: hsl(120, 100%, 40%);">+ subscr_create_on_demand(gsup->imsi);</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span> /* initialize return message structure */</span><br><span> memset(&gsup_out, 0, sizeof(gsup_out));</span><br><span> memcpy(&gsup_out.imsi, &gsup->imsi, sizeof(gsup_out.imsi));</span><br><span>@@ -291,6 +305,8 @@</span><br><span> }</span><br><span> llist_add(&luop->list, &g_lu_ops);</span><br><span> </span><br><span style="color: hsl(120, 100%, 40%);">+ subscr_create_on_demand(gsup->imsi);</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span> /* Roughly follwing "Process Update_Location_HLR" of TS 09.02 */</span><br><span> </span><br><span> /* check if subscriber is known at all */</span><br><span>diff --git a/src/hlr.h b/src/hlr.h</span><br><span>index 00fa43c..dc1c720 100644</span><br><span>--- a/src/hlr.h</span><br><span>+++ b/src/hlr.h</span><br><span>@@ -53,6 +53,7 @@</span><br><span> struct llist_head ss_sessions;</span><br><span> </span><br><span> bool store_imei;</span><br><span style="color: hsl(120, 100%, 40%);">+ bool create_subscr_on_demand;</span><br><span> };</span><br><span> </span><br><span> extern struct hlr *g_hlr;</span><br><span>diff --git a/src/hlr_vty.c b/src/hlr_vty.c</span><br><span>index d0a623a..7bf27da 100644</span><br><span>--- a/src/hlr_vty.c</span><br><span>+++ b/src/hlr_vty.c</span><br><span>@@ -325,6 +325,23 @@</span><br><span> return CMD_SUCCESS;</span><br><span> }</span><br><span> </span><br><span style="color: hsl(120, 100%, 40%);">+DEFUN(cfg_subscr_create_on_demand, cfg_subscr_create_on_demand_cmd,</span><br><span style="color: hsl(120, 100%, 40%);">+ "subscriber-create-on-demand",</span><br><span style="color: hsl(120, 100%, 40%);">+ "Make a new record when a subscriber is first seen. If you enable this feature, you must also enforce checking"</span><br><span style="color: hsl(120, 100%, 40%);">+ " the IMEI in your MSC (OsmoMSC: 'check-imei-rqd 1').")</span><br><span style="color: hsl(120, 100%, 40%);">+{</span><br><span style="color: hsl(120, 100%, 40%);">+ g_hlr->create_subscr_on_demand = true;</span><br><span style="color: hsl(120, 100%, 40%);">+ return CMD_SUCCESS;</span><br><span style="color: hsl(120, 100%, 40%);">+}</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+DEFUN(cfg_no_subscr_create_on_demand, cfg_no_subscr_create_on_demand_cmd,</span><br><span style="color: hsl(120, 100%, 40%);">+ "no subscriber-create-on-demand",</span><br><span style="color: hsl(120, 100%, 40%);">+ "Do not make a new record when a subscriber is first seen.")</span><br><span style="color: hsl(120, 100%, 40%);">+{</span><br><span style="color: hsl(120, 100%, 40%);">+ g_hlr->create_subscr_on_demand = false;</span><br><span style="color: hsl(120, 100%, 40%);">+ return CMD_SUCCESS;</span><br><span style="color: hsl(120, 100%, 40%);">+}</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span> /***********************************************************************</span><br><span> * Common Code</span><br><span> ***********************************************************************/</span><br><span>@@ -391,6 +408,8 @@</span><br><span> install_element(HLR_NODE, &cfg_ncss_guard_timeout_cmd);</span><br><span> install_element(HLR_NODE, &cfg_store_imei_cmd);</span><br><span> install_element(HLR_NODE, &cfg_no_store_imei_cmd);</span><br><span style="color: hsl(120, 100%, 40%);">+ install_element(HLR_NODE, &cfg_subscr_create_on_demand_cmd);</span><br><span style="color: hsl(120, 100%, 40%);">+ install_element(HLR_NODE, &cfg_no_subscr_create_on_demand_cmd);</span><br><span> </span><br><span> hlr_vty_subscriber_init();</span><br><span> }</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/13713">change 13713</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/13713"/><meta itemprop="name" content="View Change"/></div></div>
<div style="display:none"> Gerrit-Project: osmo-hlr </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>
<div style="display:none"> Gerrit-Change-Id: I0c9fe93f5c24b5e9fefb513c4d049fb7ebd47ecd </div>
<div style="display:none"> Gerrit-Change-Number: 13713 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Vadim Yanitskiy <axilirator@gmail.com> </div>
<div style="display:none"> Gerrit-Reviewer: osmith <osmith@sysmocom.de> </div>