<p>Harald Welte <strong>merged</strong> this change.</p><p><a href="https://gerrit.osmocom.org/13674">View Change</a></p><div style="white-space:pre-wrap">Approvals:
Jenkins Builder: Verified
Harald Welte: Looks good to me, approved
</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">remove SWO pin initialisation<br><br>using the SWO signal on TX has the advantage of being able to<br>have printf debug while still using SERCOM7 in ISO7816 mode for<br>the SIM card, but it has two drawbacks:<br>- SWO outputs data only if a debug session is ongoing (e.g. a SWD<br>debugger is connected). this saves output processing when no SWD<br>is connected, but it is not possible to force output without<br>having an SWD debugger connect (confirmed by Microchip help),<br>which is not convenient for simple UART debugging.<br>- no input is possible (SWO can only output).<br><br>Thus instead we will still use SERCOM7 for UART debug, allowing<br>commands to be input.<br>SERCOM7 should only be used for UART debug when no card in present<br>in SIM7.<br>This check in not yet implemented.<br><br>Change-Id: I199d6e356129526e65d5d1075a264eb35904d099<br>---<br>M sysmoOCTSIM/driver_init.c<br>1 file changed, 0 insertions(+), 47 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/sysmoOCTSIM/driver_init.c b/sysmoOCTSIM/driver_init.c</span><br><span>index 06184ee..726129d 100644</span><br><span>--- a/sysmoOCTSIM/driver_init.c</span><br><span>+++ b/sysmoOCTSIM/driver_init.c</span><br><span>@@ -702,53 +702,6 @@</span><br><span> </span><br><span> gpio_set_pin_function(SDA1, GPIO_PIN_FUNCTION_OFF);</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">- // GPIO on PB30</span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span style="color: hsl(0, 100%, 40%);">- gpio_set_pin_direction(UART_TX,</span><br><span style="color: hsl(0, 100%, 40%);">- // <y> Pin direction</span><br><span style="color: hsl(0, 100%, 40%);">- // <id> pad_direction</span><br><span style="color: hsl(0, 100%, 40%);">- // <GPIO_DIRECTION_OFF"> Off</span><br><span style="color: hsl(0, 100%, 40%);">- // <GPIO_DIRECTION_IN"> In</span><br><span style="color: hsl(0, 100%, 40%);">- // <GPIO_DIRECTION_OUT"> Out</span><br><span style="color: hsl(0, 100%, 40%);">- GPIO_DIRECTION_OUT);</span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span style="color: hsl(0, 100%, 40%);">- gpio_set_pin_level(UART_TX,</span><br><span style="color: hsl(0, 100%, 40%);">- // <y> Initial level</span><br><span style="color: hsl(0, 100%, 40%);">- // <id> pad_initial_level</span><br><span style="color: hsl(0, 100%, 40%);">- // <false"> Low</span><br><span style="color: hsl(0, 100%, 40%);">- // <true"> High</span><br><span style="color: hsl(0, 100%, 40%);">- false);</span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span style="color: hsl(0, 100%, 40%);">- gpio_set_pin_pull_mode(UART_TX,</span><br><span style="color: hsl(0, 100%, 40%);">- // <y> Pull configuration</span><br><span style="color: hsl(0, 100%, 40%);">- // <id> pad_pull_config</span><br><span style="color: hsl(0, 100%, 40%);">- // <GPIO_PULL_OFF"> Off</span><br><span style="color: hsl(0, 100%, 40%);">- // <GPIO_PULL_UP"> Pull-up</span><br><span style="color: hsl(0, 100%, 40%);">- // <GPIO_PULL_DOWN"> Pull-down</span><br><span style="color: hsl(0, 100%, 40%);">- GPIO_PULL_OFF);</span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span style="color: hsl(0, 100%, 40%);">- gpio_set_pin_function(UART_TX,</span><br><span style="color: hsl(0, 100%, 40%);">- // <y> Pin function</span><br><span style="color: hsl(0, 100%, 40%);">- // <id> pad_function</span><br><span style="color: hsl(0, 100%, 40%);">- // <i> Auto : use driver pinmux if signal is imported by driver, else turn off function</span><br><span style="color: hsl(0, 100%, 40%);">- // <GPIO_PIN_FUNCTION_OFF"> Auto</span><br><span style="color: hsl(0, 100%, 40%);">- // <GPIO_PIN_FUNCTION_OFF"> Off</span><br><span style="color: hsl(0, 100%, 40%);">- // <GPIO_PIN_FUNCTION_A"> A</span><br><span style="color: hsl(0, 100%, 40%);">- // <GPIO_PIN_FUNCTION_B"> B</span><br><span style="color: hsl(0, 100%, 40%);">- // <GPIO_PIN_FUNCTION_C"> C</span><br><span style="color: hsl(0, 100%, 40%);">- // <GPIO_PIN_FUNCTION_D"> D</span><br><span style="color: hsl(0, 100%, 40%);">- // <GPIO_PIN_FUNCTION_E"> E</span><br><span style="color: hsl(0, 100%, 40%);">- // <GPIO_PIN_FUNCTION_F"> F</span><br><span style="color: hsl(0, 100%, 40%);">- // <GPIO_PIN_FUNCTION_G"> G</span><br><span style="color: hsl(0, 100%, 40%);">- // <GPIO_PIN_FUNCTION_H"> H</span><br><span style="color: hsl(0, 100%, 40%);">- // <GPIO_PIN_FUNCTION_I"> I</span><br><span style="color: hsl(0, 100%, 40%);">- // <GPIO_PIN_FUNCTION_J"> J</span><br><span style="color: hsl(0, 100%, 40%);">- // <GPIO_PIN_FUNCTION_K"> K</span><br><span style="color: hsl(0, 100%, 40%);">- // <GPIO_PIN_FUNCTION_L"> L</span><br><span style="color: hsl(0, 100%, 40%);">- // <GPIO_PIN_FUNCTION_M"> M</span><br><span style="color: hsl(0, 100%, 40%);">- // <GPIO_PIN_FUNCTION_N"> N</span><br><span style="color: hsl(0, 100%, 40%);">- GPIO_PIN_FUNCTION_H);</span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span> // GPIO on PC00</span><br><span> </span><br><span> // Set pin direction to input</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/13674">change 13674</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/13674"/><meta itemprop="name" content="View Change"/></div></div>
<div style="display:none"> Gerrit-Project: osmo-ccid-firmware </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: merged </div>
<div style="display:none"> Gerrit-Change-Id: I199d6e356129526e65d5d1075a264eb35904d099 </div>
<div style="display:none"> Gerrit-Change-Number: 13674 </div>
<div style="display:none"> Gerrit-PatchSet: 7 </div>
<div style="display:none"> Gerrit-Owner: Kévin Redon <kredon@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: Harald Welte <laforge@gnumonks.org> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder (1000002) </div>