<p>Harald Welte <strong>merged</strong> this change.</p><p><a href="https://gerrit.osmocom.org/13668">View Change</a></p><div style="white-space:pre-wrap">Approvals:
  Harald Welte: Looks good to me, approved
  Jenkins Builder: Verified

</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">ncn8025: Invert the software logic of RSTIN<br><br>In hardware, the Card RST pin is low-active.  There's a level<br>translator in the NCN8025, but there's no logic inversion, so RSTIN<br>is also low-active.  In software, we have the policy of all signals<br>being "true-active", i.e. true represents the active state, and false<br>the inactive state.<br><br>Hence, we must invert the logic of how we handle rstin.<br><br>Change-Id: Ia45246b7517b2e6ecb01d22b3af52aee7a51de64<br>---<br>M sysmoOCTSIM/ncn8025.c<br>1 file changed, 2 insertions(+), 2 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/sysmoOCTSIM/ncn8025.c b/sysmoOCTSIM/ncn8025.c</span><br><span>index 61509bc..711b082 100644</span><br><span>--- a/sysmoOCTSIM/ncn8025.c</span><br><span>+++ b/sysmoOCTSIM/ncn8025.c</span><br><span>@@ -21,7 +21,7 @@</span><br><span> static uint8_t ncn8025_encode(const struct ncn8025_settings *set)</span><br><span> {</span><br><span>       uint8_t reg = 0;</span><br><span style="color: hsl(0, 100%, 40%);">-        if (set->rstin)</span><br><span style="color: hsl(120, 100%, 40%);">+    if (!set->rstin)</span><br><span>          reg |= 0x01;</span><br><span>         if (!set->cmdvcc)</span><br><span>                 reg |= 0x02;</span><br><span>@@ -43,7 +43,7 @@</span><br><span> {</span><br><span>        memset(set, 0, sizeof(*set));</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-       if (reg & 0x01)</span><br><span style="color: hsl(120, 100%, 40%);">+   if (!(reg & 0x01))</span><br><span>               set->rstin = true;</span><br><span>        if (!(reg & 0x02))</span><br><span>               set->cmdvcc = true;</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/13668">change 13668</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/13668"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-ccid-firmware </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: merged </div>
<div style="display:none"> Gerrit-Change-Id: Ia45246b7517b2e6ecb01d22b3af52aee7a51de64 </div>
<div style="display:none"> Gerrit-Change-Number: 13668 </div>
<div style="display:none"> Gerrit-PatchSet: 2 </div>
<div style="display:none"> Gerrit-Owner: Harald Welte <laforge@gnumonks.org> </div>
<div style="display:none"> Gerrit-Reviewer: Harald Welte <laforge@gnumonks.org> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder (1000002) </div>