<p>Vadim Yanitskiy has uploaded this change for <strong>review</strong>.</p><p><a href="https://gerrit.osmocom.org/13643">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">configure.ac: drop useless check for -fvisibility=hidden<br><br>This looks like a rudiment from OpenBSC, where we have:<br><br>  #define BSC_API __attribute__((visibility("default")))<br><br>However, we don't use this attribute in OsmoMSC.<br><br>Change-Id: Ie2f18e9b47eca478f6e4702606068814546e34ce<br>---<br>M configure.ac<br>1 file changed, 0 insertions(+), 12 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://gerrit.osmocom.org:29418/osmo-msc refs/changes/43/13643/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/configure.ac b/configure.ac</span><br><span>index f8787cf..e500375 100644</span><br><span>--- a/configure.ac</span><br><span>+++ b/configure.ac</span><br><span>@@ -119,18 +119,6 @@</span><br><span> </span><br><span> </span><br><span> dnl Checks for typedefs, structures and compiler characteristics</span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span style="color: hsl(0, 100%, 40%);">-# The following test is taken from WebKit's webkit.m4</span><br><span style="color: hsl(0, 100%, 40%);">-saved_CFLAGS="$CFLAGS"</span><br><span style="color: hsl(0, 100%, 40%);">-CFLAGS="$CFLAGS -fvisibility=hidden "</span><br><span style="color: hsl(0, 100%, 40%);">-AC_MSG_CHECKING([if ${CC} supports -fvisibility=hidden])</span><br><span style="color: hsl(0, 100%, 40%);">-AC_COMPILE_IFELSE([AC_LANG_SOURCE([char foo;])],</span><br><span style="color: hsl(0, 100%, 40%);">-      [ AC_MSG_RESULT([yes])</span><br><span style="color: hsl(0, 100%, 40%);">-        SYMBOL_VISIBILITY="-fvisibility=hidden"],</span><br><span style="color: hsl(0, 100%, 40%);">-        AC_MSG_RESULT([no]))</span><br><span style="color: hsl(0, 100%, 40%);">-CFLAGS="$saved_CFLAGS"</span><br><span style="color: hsl(0, 100%, 40%);">-AC_SUBST(SYMBOL_VISIBILITY)</span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span> AX_CHECK_COMPILE_FLAG([-Werror=implicit], [CFLAGS="$CFLAGS -Werror=implicit"])</span><br><span> AX_CHECK_COMPILE_FLAG([-Werror=maybe-uninitialized], [CFLAGS="$CFLAGS -Werror=maybe-uninitialized"])</span><br><span> AX_CHECK_COMPILE_FLAG([-Werror=memset-transposed-args], [CFLAGS="$CFLAGS -Werror=memset-transposed-args"])</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/13643">change 13643</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/13643"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-msc </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>
<div style="display:none"> Gerrit-Change-Id: Ie2f18e9b47eca478f6e4702606068814546e34ce </div>
<div style="display:none"> Gerrit-Change-Number: 13643 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Vadim Yanitskiy <axilirator@gmail.com> </div>