<p>Vadim Yanitskiy has uploaded this change for <strong>review</strong>.</p><p><a href="https://gerrit.osmocom.org/13625">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">gb/gprs_ns_sns.c: fix incorrect buffer size calculation<br><br>Calling sizeof() on a pointer to dynamically allocated memory would<br>result in getting size of the pointer (usually 4 or 8 bytes) itself,<br>but not the size of allocated memory.<br><br>Change-Id: I83f55a9638b75d9097d37992f7c84707791f10f6<br>Fixes: CID#194266<br>---<br>M src/gb/gprs_ns_sns.c<br>1 file changed, 1 insertion(+), 1 deletion(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/25/13625/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/gb/gprs_ns_sns.c b/src/gb/gprs_ns_sns.c</span><br><span>index dd8d3a2..aa8b121 100644</span><br><span>--- a/src/gb/gprs_ns_sns.c</span><br><span>+++ b/src/gb/gprs_ns_sns.c</span><br><span>@@ -498,7 +498,7 @@</span><br><span>                       }</span><br><span>                    /* make a copy as do_sns_delete() will change the array underneath us */</span><br><span>                     ip4_remote = talloc_memdup(fi, gss->ip4_remote,</span><br><span style="color: hsl(0, 100%, 40%);">-                                                 gss->num_ip4_remote*sizeof(v4_list));</span><br><span style="color: hsl(120, 100%, 40%);">+                                              gss->num_ip4_remote*sizeof(*v4_list));</span><br><span>                         for (i = 0; i < gss->num_ip4_remote; i++) {</span><br><span>                            if (ip4_remote[i].ip_addr == ip_addr) {</span><br><span>                                      rc = do_sns_delete(fi, &ip4_remote[i]);</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/13625">change 13625</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/13625"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: libosmocore </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>
<div style="display:none"> Gerrit-Change-Id: I83f55a9638b75d9097d37992f7c84707791f10f6 </div>
<div style="display:none"> Gerrit-Change-Number: 13625 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Vadim Yanitskiy <axilirator@gmail.com> </div>