<p>osmith <strong>merged</strong> this change.</p><p><a href="https://gerrit.osmocom.org/13548">View Change</a></p><div style="white-space:pre-wrap">Approvals:
  Harald Welte: Looks good to me, approved
  Vadim Yanitskiy: Looks good to me, but someone else must approve
  Jenkins Builder: Verified

</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">USSD: don't use gsm0480_msgb_alloc_name()<br><br>We have nothing to do with GSM 04.80 at the HLR - it's only used to<br>encapsulate the SS payload between MS and MSC. This is not that<br>critical, but may be misleading.<br><br>Also, gsm0480_msgb_alloc_name() allocates a smaller buffer:<br><br>  return msgb_alloc_headroom(1024, 128, name);<br><br>than osmo_gsup_client_msgb_alloc() does:<br><br>  return msgb_alloc_headroom(4000, 64, __func__);<br><br>Change-Id: Icdab40c6a933888eb9f51bee9c5264c8919dbf7b<br>---<br>M src/hlr_ussd.c<br>1 file changed, 1 insertion(+), 1 deletion(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/hlr_ussd.c b/src/hlr_ussd.c</span><br><span>index 56a5a95..50a0167 100644</span><br><span>--- a/src/hlr_ussd.c</span><br><span>+++ b/src/hlr_ussd.c</span><br><span>@@ -277,7 +277,7 @@</span><br><span>              resp.ss_info_len = msgb_length(ss_msg);</span><br><span>      }</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-   resp_msg = gsm0480_msgb_alloc_name(__func__);</span><br><span style="color: hsl(120, 100%, 40%);">+ resp_msg = msgb_alloc_headroom(4000, 64, __func__);</span><br><span>  OSMO_ASSERT(resp_msg);</span><br><span>       osmo_gsup_encode(resp_msg, &resp);</span><br><span>       msgb_free(ss_msg);</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/13548">change 13548</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/13548"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-hlr </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: merged </div>
<div style="display:none"> Gerrit-Change-Id: Icdab40c6a933888eb9f51bee9c5264c8919dbf7b </div>
<div style="display:none"> Gerrit-Change-Number: 13548 </div>
<div style="display:none"> Gerrit-PatchSet: 2 </div>
<div style="display:none"> Gerrit-Owner: osmith <osmith@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: Harald Welte <laforge@gnumonks.org> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder (1000002) </div>
<div style="display:none"> Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: Pau Espin Pedrol <pespin@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: Vadim Yanitskiy <axilirator@gmail.com> </div>
<div style="display:none"> Gerrit-Reviewer: osmith <osmith@sysmocom.de> </div>