<p>Patch set 5:<span style="border-radius: 3px; display: inline-block; margin: 0 2px; padding: 4px;background-color: #d4ffd4;">Code-Review +1</span></p><p><a href="https://gerrit.osmocom.org/13564">View Change</a></p><p>2 comments:</p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0;"><p><a href="https://gerrit.osmocom.org/#/c/13564/5/ggsn_tests/GGSN_Tests.ttcn">File ggsn_tests/GGSN_Tests.ttcn:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.osmocom.org/#/c/13564/5/ggsn_tests/GGSN_Tests.ttcn@943">Patch Set #5, Line 943:</a> <code style="font-family:monospace,monospace">                  setverdict(fail, "PAP isn't an AuthenticateAck: ", pap);</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">so iiuc this means some code is needed in osmo-ggsn which answers this and basically allows everybody no matter the PAP credentials provided (as if PAP was not used, as until now).</p></li></ul></li><li style="margin: 0; padding: 0;"><p><a href="https://gerrit.osmocom.org/#/c/13564/5/library/GTP_Templates.ttcn">File library/GTP_Templates.ttcn:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.osmocom.org/#/c/13564/5/library/GTP_Templates.ttcn@466">Patch Set #5, Line 466:</a> <code style="font-family:monospace,monospace">          protoIDContents := '0100003c0444435338323700bc1c08087c1508083e00790000150808fd06000001000000000000000000000000000000000000000000000000000000'O</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">lol. Some description/comment here would be welcome.</p></li></ul></li></ul><p>To view, visit <a href="https://gerrit.osmocom.org/13564">change 13564</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/13564"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-ttcn3-hacks </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: comment </div>
<div style="display:none"> Gerrit-Change-Id: Ie89d984ed9e26fbbb2e4914bdb8623446d462a4c </div>
<div style="display:none"> Gerrit-Change-Number: 13564 </div>
<div style="display:none"> Gerrit-PatchSet: 5 </div>
<div style="display:none"> Gerrit-Owner: Harald Welte <laforge@gnumonks.org> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder (1000002) </div>
<div style="display:none"> Gerrit-Reviewer: Pau Espin Pedrol <pespin@sysmocom.de> </div>
<div style="display:none"> Gerrit-Comment-Date: Thu, 11 Apr 2019 19:26:23 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>
<div style="display:none"> Gerrit-HasLabels: Yes </div>