<p>Patch set 3:<span style="border-radius: 3px; display: inline-block; margin: 0 2px; padding: 4px;background-color: #ffd4d4;">Code-Review -1</span></p><p><a href="https://gerrit.osmocom.org/13576">View Change</a></p><p>3 comments:</p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0;"><p><a href="https://gerrit.osmocom.org/#/c/13576/3/include/osmocom/gsm/gsup.h">File include/osmocom/gsm/gsup.h:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.osmocom.org/#/c/13576/3/include/osmocom/gsm/gsup.h@71">Patch Set #3, Line 71:</a> <code style="font-family:monospace,monospace">OSMO_GSUP_CLASS_IE</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">Looking at this IE, the reader may ask: class of what?<br>How about 'OSMO_GSUP_MSG_CLASS_IE' or 'OSMO_GSUP_MESSAGE_CLASS_IE'?</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.osmocom.org/#/c/13576/3/include/osmocom/gsm/gsup.h@233">Patch Set #3, Line 233:</a> <code style="font-family:monospace,monospace">osmo_gsup_class</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">Same comment regarding the naming here.</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.osmocom.org/#/c/13576/3/include/osmocom/gsm/gsup.h@241">Patch Set #3, Line 241:</a> <code style="font-family:monospace,monospace">OSMO_GSUP_CLASS_ARRAYSIZE</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">Which array?</p><p style="white-space: pre-wrap; word-wrap: break-word;">Enum osmo_gsup_iei has '_OSMO_GSUP_IEI_END_MARKER'.<br>I think we should keep the naming style consistent.</p></li></ul></li></ul><p>To view, visit <a href="https://gerrit.osmocom.org/13576">change 13576</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/13576"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: libosmocore </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: comment </div>
<div style="display:none"> Gerrit-Change-Id: Ic397a9f2c4a7224e47cab944c72e75ca5592efef </div>
<div style="display:none"> Gerrit-Change-Number: 13576 </div>
<div style="display:none"> Gerrit-PatchSet: 3 </div>
<div style="display:none"> Gerrit-Owner: Neels Hofmeyr <nhofmeyr@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: Harald Welte <laforge@gnumonks.org> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder (1000002) </div>
<div style="display:none"> Gerrit-Reviewer: Vadim Yanitskiy <axilirator@gmail.com> </div>
<div style="display:none"> Gerrit-Comment-Date: Thu, 11 Apr 2019 08:54:47 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>
<div style="display:none"> Gerrit-HasLabels: Yes </div>