<p>Harald Welte has uploaded this change for <strong>review</strong>.</p><p><a href="https://gerrit.osmocom.org/13566">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">process_pco() const-ify 'apn' argument<br><br>Change-Id: I2a96b0fbe077c7c49342553de0880bfc58318669<br>---<br>M ggsn/ggsn.c<br>1 file changed, 4 insertions(+), 4 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://gerrit.osmocom.org:29418/osmo-ggsn refs/changes/66/13566/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/ggsn/ggsn.c b/ggsn/ggsn.c</span><br><span>index 39695b9..2ee9b1a 100644</span><br><span>--- a/ggsn/ggsn.c</span><br><span>+++ b/ggsn/ggsn.c</span><br><span>@@ -503,7 +503,7 @@</span><br><span> }</span><br><span> </span><br><span> /* construct an IPCP PCO response from request*/</span><br><span style="color: hsl(0, 100%, 40%);">-static void build_ipcp_pco(struct apn_ctx *apn, struct pdp_t *pdp, struct msgb *msg)</span><br><span style="color: hsl(120, 100%, 40%);">+static void build_ipcp_pco(const struct apn_ctx *apn, struct pdp_t *pdp, struct msgb *msg)</span><br><span> {</span><br><span>     const struct in46_addr *dns1 = &apn->v4.cfg.dns[0];</span><br><span>   const struct in46_addr *dns2 = &apn->v4.cfg.dns[1];</span><br><span>@@ -559,7 +559,7 @@</span><br><span> }</span><br><span> </span><br><span> /* process one PCO request from a MS/UE, putting together the proper responses */</span><br><span style="color: hsl(0, 100%, 40%);">-static void process_pco(struct apn_ctx *apn, struct pdp_t *pdp)</span><br><span style="color: hsl(120, 100%, 40%);">+static void process_pco(const struct apn_ctx *apn, struct pdp_t *pdp)</span><br><span> {</span><br><span>    struct msgb *msg = msgb_alloc(256, "PCO");</span><br><span>         struct ippoolm_t *peer_v4 = pdp_get_peer_ipv(pdp, false);</span><br><span>@@ -573,7 +573,7 @@</span><br><span> </span><br><span>  if (pco_contains_proto(&pdp->pco_req, 0, PCO_P_DNS_IPv6_ADDR, 0)) {</span><br><span>           for (i = 0; i < ARRAY_SIZE(apn->v6.cfg.dns); i++) {</span><br><span style="color: hsl(0, 100%, 40%);">-                       struct in46_addr *i46a = &apn->v6.cfg.dns[i];</span><br><span style="color: hsl(120, 100%, 40%);">+                  const struct in46_addr *i46a = &apn->v6.cfg.dns[i];</span><br><span>                   if (i46a->len != 16)</span><br><span>                              continue;</span><br><span>                    msgb_t16lv_put(msg, PCO_P_DNS_IPv6_ADDR, i46a->len, i46a->v6.s6_addr);</span><br><span>@@ -582,7 +582,7 @@</span><br><span> </span><br><span>       if (pco_contains_proto(&pdp->pco_req, 0, PCO_P_DNS_IPv4_ADDR, 0)) {</span><br><span>           for (i = 0; i < ARRAY_SIZE(apn->v4.cfg.dns); i++) {</span><br><span style="color: hsl(0, 100%, 40%);">-                       struct in46_addr *i46a = &apn->v4.cfg.dns[i];</span><br><span style="color: hsl(120, 100%, 40%);">+                  const struct in46_addr *i46a = &apn->v4.cfg.dns[i];</span><br><span>                   if (i46a->len != 4)</span><br><span>                               continue;</span><br><span>                    msgb_t16lv_put(msg, PCO_P_DNS_IPv4_ADDR, i46a->len, (uint8_t *)&i46a->v4);</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/13566">change 13566</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/13566"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-ggsn </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>
<div style="display:none"> Gerrit-Change-Id: I2a96b0fbe077c7c49342553de0880bfc58318669 </div>
<div style="display:none"> Gerrit-Change-Number: 13566 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Harald Welte <laforge@gnumonks.org> </div>