<p>Vadim Yanitskiy <strong>merged</strong> this change.</p><p><a href="https://gerrit.osmocom.org/13560">View Change</a></p><div style="white-space:pre-wrap">Approvals:
  Vadim Yanitskiy: Looks good to me, approved
  Pau Espin Pedrol: Looks good to me, approved
  Jenkins Builder: Verified

</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">smpp_smsc: Call destroy_tlv() when using build_tlv()<br><br>The libsmpp34 build_tlv() function is allocating dynamic memory<br>which we need to release again by calling destroy_tlv().<br><br>Change-Id: Iacc74c9948fb10fa79c0dd7b0cb72d4adbefdeed<br>Closes: OS#3912<br>---<br>M src/libmsc/smpp_smsc.c<br>1 file changed, 7 insertions(+), 2 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/libmsc/smpp_smsc.c b/src/libmsc/smpp_smsc.c</span><br><span>index 2350d84..3bfb81a 100644</span><br><span>--- a/src/libmsc/smpp_smsc.c</span><br><span>+++ b/src/libmsc/smpp_smsc.c</span><br><span>@@ -520,7 +520,9 @@</span><br><span>       tlv.value.val16 = esme->smpp_version;</span><br><span>     build_tlv(&bind_r.tlv, &tlv);</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-       return PACK_AND_SEND(esme, &bind_r);</span><br><span style="color: hsl(120, 100%, 40%);">+      rc = PACK_AND_SEND(esme, &bind_r);</span><br><span style="color: hsl(120, 100%, 40%);">+        destroy_tlv(bind_r.tlv);</span><br><span style="color: hsl(120, 100%, 40%);">+      return rc;</span><br><span> }</span><br><span> </span><br><span> /*! \brief handle an incoming SMPP BIND TRANSCEIVER */</span><br><span>@@ -632,6 +634,7 @@</span><br><span> {</span><br><span>     struct alert_notification_t alert;</span><br><span>   struct tlv_t tlv;</span><br><span style="color: hsl(120, 100%, 40%);">+     int rc;</span><br><span> </span><br><span>  memset(&alert, 0, sizeof(alert));</span><br><span>        alert.command_length    = 0;</span><br><span>@@ -652,7 +655,9 @@</span><br><span>           alert.source_addr_npi,</span><br><span>               get_value_string(smpp_avail_strs, avail_status));</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-   return PACK_AND_SEND(esme, &alert);</span><br><span style="color: hsl(120, 100%, 40%);">+       rc = PACK_AND_SEND(esme, &alert);</span><br><span style="color: hsl(120, 100%, 40%);">+ destroy_tlv(alert.tlv);</span><br><span style="color: hsl(120, 100%, 40%);">+       return rc;</span><br><span> }</span><br><span> </span><br><span> /* \brief send a DELIVER-SM message to given ESME */</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/13560">change 13560</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/13560"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-msc </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: merged </div>
<div style="display:none"> Gerrit-Change-Id: Iacc74c9948fb10fa79c0dd7b0cb72d4adbefdeed </div>
<div style="display:none"> Gerrit-Change-Number: 13560 </div>
<div style="display:none"> Gerrit-PatchSet: 3 </div>
<div style="display:none"> Gerrit-Owner: Harald Welte <laforge@gnumonks.org> </div>
<div style="display:none"> Gerrit-Assignee: fixeria <axilirator@gmail.com> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder (1000002) </div>
<div style="display:none"> Gerrit-Reviewer: Pau Espin Pedrol <pespin@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: Vadim Yanitskiy <axilirator@gmail.com> </div>
<div style="display:none"> Gerrit-CC: fixeria <axilirator@gmail.com> </div>