<p>Harald Welte has uploaded this change for <strong>review</strong>.</p><p><a href="https://gerrit.osmocom.org/13564">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">ggsn: Add TC_pdp4_act_deact_ipcp_pap_broken()<br><br>This test case reproduces a real-world PCO capture including a broken<br>PAP AuthenticationReq. It triggers some weird behavior in OsmoGGSN<br>1.3.0 where it would send duplicate IPCP repsonses and no PAP response.<br><br>Change-Id: Ie89d984ed9e26fbbb2e4914bdb8623446d462a4c<br>Related: OS#3914<br>---<br>M ggsn_tests/GGSN_Tests.ttcn<br>M library/GTP_Templates.ttcn<br>2 files changed, 40 insertions(+), 0 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/64/13564/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/ggsn_tests/GGSN_Tests.ttcn b/ggsn_tests/GGSN_Tests.ttcn</span><br><span>index 9370904..c42ee21 100644</span><br><span>--- a/ggsn_tests/GGSN_Tests.ttcn</span><br><span>+++ b/ggsn_tests/GGSN_Tests.ttcn</span><br><span>@@ -899,6 +899,35 @@</span><br><span> f_pdp_ctx_del(ctx, '1'B);</span><br><span> }</span><br><span> </span><br><span style="color: hsl(120, 100%, 40%);">+ /* Test PDP context activation for dynamic IPv4 EUA with IPv4 DNS in IPCP + PAP authentication (broken) */</span><br><span style="color: hsl(120, 100%, 40%);">+ testcase TC_pdp4_act_deact_ipcp_pap_broken() runs on GT_CT {</span><br><span style="color: hsl(120, 100%, 40%);">+ f_init();</span><br><span style="color: hsl(120, 100%, 40%);">+ var OCT4 ggsn_ip4_dns1 := f_inet_addr(m_ggsn_ip4_dns1);</span><br><span style="color: hsl(120, 100%, 40%);">+ var OCT4 ggsn_ip4_dns2 := f_inet_addr(m_ggsn_ip4_dns2);</span><br><span style="color: hsl(120, 100%, 40%);">+ var PdpContext ctx := valueof(t_DefinePDP(f_rnd_imsi('26242'H), '1234'O, c_ApnInternet, valueof(t_EuaIPv4Dyn)));</span><br><span style="color: hsl(120, 100%, 40%);">+ ctx.pco_req := valueof(ts_PCO_PAP_IPv4_DNS);</span><br><span style="color: hsl(120, 100%, 40%);">+ f_pdp_ctx_act(ctx);</span><br><span style="color: hsl(120, 100%, 40%);">+ f_PCO_ensure_no_duplicates(ctx.pco_neg);</span><br><span style="color: hsl(120, 100%, 40%);">+ /* verify IPCP is at all contained */</span><br><span style="color: hsl(120, 100%, 40%);">+ if (not match(ctx.pco_neg, tr_PCO_Contains('8021'O))) {</span><br><span style="color: hsl(120, 100%, 40%);">+ setverdict(fail, "IPCP not found in PCO");</span><br><span style="color: hsl(120, 100%, 40%);">+ }</span><br><span style="color: hsl(120, 100%, 40%);">+ /* verify IPCP contains both primary and secondary DNS */</span><br><span style="color: hsl(120, 100%, 40%);">+ var IpcpPacket ipcp := dec_IpcpPacket(f_PCO_extract_proto(ctx.pco_neg, '8021'O));</span><br><span style="color: hsl(120, 100%, 40%);">+ if (not match(ipcp, tr_IPCP_Ack_DNS(0, ggsn_ip4_dns1, ggsn_ip4_dns2))) {</span><br><span style="color: hsl(120, 100%, 40%);">+ if (not match(ipcp, tr_IPCP_Ack_DNS(0))) {</span><br><span style="color: hsl(120, 100%, 40%);">+ setverdict(fail, "Primary/Secondary DNS PCO IPCP option not found");</span><br><span style="color: hsl(120, 100%, 40%);">+ } else {</span><br><span style="color: hsl(120, 100%, 40%);">+ setverdict(fail, "Primary/Secondary DNS PCO IPCP option found but not matching expected values");</span><br><span style="color: hsl(120, 100%, 40%);">+ }</span><br><span style="color: hsl(120, 100%, 40%);">+ }</span><br><span style="color: hsl(120, 100%, 40%);">+ /* verify that PAP is contained */</span><br><span style="color: hsl(120, 100%, 40%);">+ if (not match(ctx.pco_neg, tr_PCO_Contains('8023'O))) {</span><br><span style="color: hsl(120, 100%, 40%);">+ setverdict(fail, "IPCP not found in PCO");</span><br><span style="color: hsl(120, 100%, 40%);">+ }</span><br><span style="color: hsl(120, 100%, 40%);">+ f_pdp_ctx_del(ctx, '1'B);</span><br><span style="color: hsl(120, 100%, 40%);">+ }</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span> /* Test PDP context activation for dynamic IPv4 EUA with IPv4 DNS in PCO */</span><br><span> testcase TC_pdp4_act_deact_pcodns() runs on GT_CT {</span><br><span> f_init();</span><br><span>diff --git a/library/GTP_Templates.ttcn b/library/GTP_Templates.ttcn</span><br><span>index bd39e27..e1f19f1 100644</span><br><span>--- a/library/GTP_Templates.ttcn</span><br><span>+++ b/library/GTP_Templates.ttcn</span><br><span>@@ -460,6 +460,17 @@</span><br><span> lengthProtoID := ?,</span><br><span> protoIDContents := ?</span><br><span> }</span><br><span style="color: hsl(120, 100%, 40%);">+ template ProtocolElement ts_PCOelem_PAP_broken := {</span><br><span style="color: hsl(120, 100%, 40%);">+ protocolID := 'C023'O,</span><br><span style="color: hsl(120, 100%, 40%);">+ lengthProtoID := 60,</span><br><span style="color: hsl(120, 100%, 40%);">+ protoIDContents := '0100003c0444435338323700bc1c08087c1508083e00790000150808fd06000001000000000000000000000000000000000000000000000000000000'O</span><br><span style="color: hsl(120, 100%, 40%);">+ }</span><br><span style="color: hsl(120, 100%, 40%);">+ template ProtConfigOptions ts_PCO_PAP_IPv4_DNS modifies ts_PCO := {</span><br><span style="color: hsl(120, 100%, 40%);">+ protocols := {</span><br><span style="color: hsl(120, 100%, 40%);">+ ts_PCOelem_PAP_broken,</span><br><span style="color: hsl(120, 100%, 40%);">+ { protocolID := '8021'O, lengthProtoID := 16, protoIDContents := enc_IpcpPacket(valueof(ts_IPCP_ReqDNS)) }</span><br><span style="color: hsl(120, 100%, 40%);">+ }</span><br><span style="color: hsl(120, 100%, 40%);">+ }</span><br><span> template ProtConfigOptions tr_PCO_Contains(OCT2 prot_id) modifies tr_PCO := {</span><br><span> protocols := { *, tr_PCO_Proto(prot_id), * }</span><br><span> }</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/13564">change 13564</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/13564"/><meta itemprop="name" content="View Change"/></div></div>
<div style="display:none"> Gerrit-Project: osmo-ttcn3-hacks </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>
<div style="display:none"> Gerrit-Change-Id: Ie89d984ed9e26fbbb2e4914bdb8623446d462a4c </div>
<div style="display:none"> Gerrit-Change-Number: 13564 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Harald Welte <laforge@gnumonks.org> </div>