<p>Harald Welte <strong>merged</strong> this change.</p><p><a href="https://gerrit.osmocom.org/12246">View Change</a></p><div style="white-space:pre-wrap">Approvals:
  Harald Welte: Looks good to me, approved
  Jenkins Builder: Verified

</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">cosmetic: use const pointer for bts_data<br><br>It's used several time for logging so let's call it once to make code<br>easier to follow.<br><br>Change-Id: Icfd9e5603a5d8701f487f17e9c0335d458e9e80b<br>---<br>M src/tbf_dl.cpp<br>M src/tbf_ul.cpp<br>2 files changed, 7 insertions(+), 4 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/tbf_dl.cpp b/src/tbf_dl.cpp</span><br><span>index c97436a..d5e4a45 100644</span><br><span>--- a/src/tbf_dl.cpp</span><br><span>+++ b/src/tbf_dl.cpp</span><br><span>@@ -1350,9 +1350,11 @@</span><br><span> </span><br><span> void gprs_rlcmac_dl_tbf::set_window_size()</span><br><span> {</span><br><span style="color: hsl(0, 100%, 40%);">-   uint16_t ws = egprs_window_size(bts->bts_data(), dl_slots());</span><br><span style="color: hsl(120, 100%, 40%);">+      const struct gprs_rlcmac_bts *b = bts->bts_data();</span><br><span style="color: hsl(120, 100%, 40%);">+ uint16_t ws = egprs_window_size(b, dl_slots());</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span>    LOGPTBFDL(this, LOGL_INFO, "setting EGPRS DL window size to %u, base(%u) slots(%u) ws_pdch(%u)\n",</span><br><span style="color: hsl(0, 100%, 40%);">-              ws, bts->bts_data()->ws_base, pcu_bitcount(dl_slots()), bts->bts_data()->ws_pdch);</span><br><span style="color: hsl(120, 100%, 40%);">+                ws, b->ws_base, pcu_bitcount(dl_slots()), b->ws_pdch);</span><br><span>       m_window.set_ws(ws);</span><br><span> }</span><br><span> </span><br><span>diff --git a/src/tbf_ul.cpp b/src/tbf_ul.cpp</span><br><span>index fd7d73b..e1a0fbd 100644</span><br><span>--- a/src/tbf_ul.cpp</span><br><span>+++ b/src/tbf_ul.cpp</span><br><span>@@ -588,8 +588,9 @@</span><br><span> </span><br><span> void gprs_rlcmac_ul_tbf::set_window_size()</span><br><span> {</span><br><span style="color: hsl(0, 100%, 40%);">- uint16_t ws = egprs_window_size(bts->bts_data(), ul_slots());</span><br><span style="color: hsl(120, 100%, 40%);">+      const struct gprs_rlcmac_bts *b = bts->bts_data();</span><br><span style="color: hsl(120, 100%, 40%);">+ uint16_t ws = egprs_window_size(b, ul_slots());</span><br><span>      LOGPTBFUL(this, LOGL_INFO, "setting EGPRS UL window size to %u, base(%u) slots(%u) ws_pdch(%u)\n",</span><br><span style="color: hsl(0, 100%, 40%);">-              ws, bts->bts_data()->ws_base, pcu_bitcount(ul_slots()), bts->bts_data()->ws_pdch);</span><br><span style="color: hsl(120, 100%, 40%);">+                ws, b->ws_base, pcu_bitcount(ul_slots()), b->ws_pdch);</span><br><span>       m_window.set_ws(ws);</span><br><span> }</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/12246">change 12246</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/12246"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-pcu </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: merged </div>
<div style="display:none"> Gerrit-Change-Id: Icfd9e5603a5d8701f487f17e9c0335d458e9e80b </div>
<div style="display:none"> Gerrit-Change-Number: 12246 </div>
<div style="display:none"> Gerrit-PatchSet: 4 </div>
<div style="display:none"> Gerrit-Owner: Max <suraev@alumni.ntnu.no> </div>
<div style="display:none"> Gerrit-Reviewer: Harald Welte <laforge@gnumonks.org> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder (1000002) </div>
<div style="display:none"> Gerrit-Reviewer: Max <suraev@alumni.ntnu.no> </div>
<div style="display:none"> Gerrit-Reviewer: Pau Espin Pedrol <pespin@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: osmith <osmith@sysmocom.de> </div>