<p>dexter <strong>merged</strong> this change.</p><p><a href="https://gerrit.osmocom.org/13272">View Change</a></p><div style="white-space:pre-wrap">Approvals:
  Jenkins Builder: Verified
  Pau Espin Pedrol: Looks good to me, approved
  Harald Welte: Looks good to me, approved

</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">oc2gbts_mgr_calib: do not return NULL on integer function<br><br>The functions oc2gbts_par_get_uptime() and oc2gbts_par_set_uptime() try<br>to return with NULL, but both functions are declared as int. Lets return<br>-EINVAL instead.<br><br>Change-Id: I63b61be2940c59b221089d3d1501371b0116d89a<br>---<br>M src/osmo-bts-oc2g/misc/oc2gbts_mgr_calib.c<br>1 file changed, 2 insertions(+), 2 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/osmo-bts-oc2g/misc/oc2gbts_mgr_calib.c b/src/osmo-bts-oc2g/misc/oc2gbts_mgr_calib.c</span><br><span>index 33c0782..3ddf0e8 100644</span><br><span>--- a/src/osmo-bts-oc2g/misc/oc2gbts_mgr_calib.c</span><br><span>+++ b/src/osmo-bts-oc2g/misc/oc2gbts_mgr_calib.c</span><br><span>@@ -87,7 +87,7 @@</span><br><span> </span><br><span>   fpath = talloc_asprintf(ctx, "%s", UPTIME_TMP_PATH);</span><br><span>       if (!fpath)</span><br><span style="color: hsl(0, 100%, 40%);">-             return NULL;</span><br><span style="color: hsl(120, 100%, 40%);">+          return -EINVAL;</span><br><span> </span><br><span>  fp = fopen(fpath, "r");</span><br><span>    if (!fp)</span><br><span>@@ -117,7 +117,7 @@</span><br><span> </span><br><span>   fpath = talloc_asprintf(ctx, "%s", UPTIME_TMP_PATH);</span><br><span>       if (!fpath)</span><br><span style="color: hsl(0, 100%, 40%);">-             return NULL;</span><br><span style="color: hsl(120, 100%, 40%);">+          return -EINVAL;</span><br><span> </span><br><span>  fp = fopen(fpath, "w");</span><br><span>    if (!fp)</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/13272">change 13272</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/13272"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-bts </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: merged </div>
<div style="display:none"> Gerrit-Change-Id: I63b61be2940c59b221089d3d1501371b0116d89a </div>
<div style="display:none"> Gerrit-Change-Number: 13272 </div>
<div style="display:none"> Gerrit-PatchSet: 4 </div>
<div style="display:none"> Gerrit-Owner: dexter <pmaier@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: Daniel Willmann <dwillmann@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: Harald Welte <laforge@gnumonks.org> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder (1000002) </div>
<div style="display:none"> Gerrit-Reviewer: Pau Espin Pedrol <pespin@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: dexter <pmaier@sysmocom.de> </div>