<p>Vadim Yanitskiy has uploaded this change for <strong>review</strong>.</p><p><a href="https://gerrit.osmocom.org/13539">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">gsm_data.c: use REG_NOSUB flag of regcomp()<br><br>We don't need to know position of matches: just yes or no.<br>This change would save some computation power.<br><br>Change-Id: Ia8414bf83d030adfae806c0aeaa757bc4c8cda2b<br>---<br>M src/osmo-bsc/gsm_data.c<br>1 file changed, 1 insertion(+), 1 deletion(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/39/13539/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/osmo-bsc/gsm_data.c b/src/osmo-bsc/gsm_data.c</span><br><span>index 509f805..45c433c 100644</span><br><span>--- a/src/osmo-bsc/gsm_data.c</span><br><span>+++ b/src/osmo-bsc/gsm_data.c</span><br><span>@@ -260,7 +260,7 @@</span><br><span> </span><br><span>        if (argc > 0) {</span><br><span>           *str = talloc_strdup(ctx, argv[0]);</span><br><span style="color: hsl(0, 100%, 40%);">-             ret = regcomp(reg, argv[0], 0);</span><br><span style="color: hsl(120, 100%, 40%);">+               ret = regcomp(reg, argv[0], REG_NOSUB);</span><br><span> </span><br><span>          /* handle compilation failures */</span><br><span>            if (ret != 0) {</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/13539">change 13539</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/13539"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-bsc </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>
<div style="display:none"> Gerrit-Change-Id: Ia8414bf83d030adfae806c0aeaa757bc4c8cda2b </div>
<div style="display:none"> Gerrit-Change-Number: 13539 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Vadim Yanitskiy <axilirator@gmail.com> </div>