<p>Vadim Yanitskiy has uploaded this change for <strong>review</strong>.</p><p><a href="https://gerrit.osmocom.org/13519">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">abis_nm.c: use proper format specifiers for BTS / TRX number<br><br>Change-Id: I429d00d1393c221070e4c9e0997cbd14ae96103e<br>---<br>M src/osmo-bsc/abis_nm.c<br>1 file changed, 6 insertions(+), 6 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/19/13519/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/osmo-bsc/abis_nm.c b/src/osmo-bsc/abis_nm.c</span><br><span>index 826c1e2..6478d81 100644</span><br><span>--- a/src/osmo-bsc/abis_nm.c</span><br><span>+++ b/src/osmo-bsc/abis_nm.c</span><br><span>@@ -1713,7 +1713,7 @@</span><br><span>              return -EINVAL;</span><br><span>      }</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-   DEBUGP(DNM, "Get Attr (bts=%d)\n", bts->nr);</span><br><span style="color: hsl(120, 100%, 40%);">+     DEBUGP(DNM, "Get Attr (bts=%u)\n", bts->nr);</span><br><span> </span><br><span>        msg = nm_msgb_alloc();</span><br><span>       oh = (struct abis_om_hdr *) msgb_put(msg, ABIS_OM_FOM_HDR_SIZE);</span><br><span>@@ -1731,7 +1731,7 @@</span><br><span>     struct msgb *msg = nm_msgb_alloc();</span><br><span>  uint8_t *cur;</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-       DEBUGP(DNM, "Set BTS Attr (bts=%d)\n", bts->nr);</span><br><span style="color: hsl(120, 100%, 40%);">+ DEBUGP(DNM, "Set BTS Attr (bts=%u)\n", bts->nr);</span><br><span> </span><br><span>    oh = (struct abis_om_hdr *) msgb_put(msg, ABIS_OM_FOM_HDR_SIZE);</span><br><span>     fill_om_fom_hdr(oh, attr_len, NM_MT_SET_BTS_ATTR, NM_OC_BTS, bts->bts_nr, 0xff, 0xff);</span><br><span>@@ -1748,7 +1748,7 @@</span><br><span>    struct msgb *msg = nm_msgb_alloc();</span><br><span>  uint8_t *cur;</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-       DEBUGP(DNM, "Set TRX Attr (bts=%d,trx=%d)\n", trx->bts->nr, trx->nr);</span><br><span style="color: hsl(120, 100%, 40%);">+      DEBUGP(DNM, "Set TRX Attr (bts=%u,trx=%u)\n", trx->bts->nr, trx->nr);</span><br><span> </span><br><span>         oh = (struct abis_om_hdr *) msgb_put(msg, ABIS_OM_FOM_HDR_SIZE);</span><br><span>     fill_om_fom_hdr(oh, attr_len, NM_MT_SET_RADIO_ATTR, NM_OC_RADIO_CARRIER,</span><br><span>@@ -2853,7 +2853,7 @@</span><br><span>     struct gsm_bts_trx *trx = data;</span><br><span>      struct ipacc_ack_signal_data signal;</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-        LOGP(DRSL, LOGL_NOTICE, "(bts=%d,trx=%d) RSL connection request timed out\n", trx->bts->nr, trx->nr);</span><br><span style="color: hsl(120, 100%, 40%);">+      LOGP(DRSL, LOGL_NOTICE, "(bts=%u,trx=%u) RSL connection request timed out\n", trx->bts->nr, trx->nr);</span><br><span> </span><br><span>         /* Fake an RSL CONECT NACK message from the BTS. */</span><br><span>  signal.trx = trx;</span><br><span>@@ -2884,7 +2884,7 @@</span><br><span>    if (ip == 0)</span><br><span>                 attr_len -= 5;</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-      LOGP(DNM, LOGL_INFO, "(bts=%d,trx=%d) IPA RSL CONNECT IP=%s PORT=%u STREAM=0x%02x\n",</span><br><span style="color: hsl(120, 100%, 40%);">+       LOGP(DNM, LOGL_INFO, "(bts=%u,trx=%u) IPA RSL CONNECT IP=%s PORT=%u STREAM=0x%02x\n",</span><br><span>              trx->bts->nr, trx->nr, inet_ntoa(ia), port, stream);</span><br><span> </span><br><span>    error = abis_nm_ipaccess_msg(trx->bts, NM_MT_IPACC_RSL_CONNECT,</span><br><span>@@ -2939,7 +2939,7 @@</span><br><span>           return;</span><br><span>      }</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-   LOGP(DNM, LOGL_NOTICE, "(bts=%d,trx=%d) Requesting administrative state change %s -> %s [%s]\n",</span><br><span style="color: hsl(120, 100%, 40%);">+ LOGP(DNM, LOGL_NOTICE, "(bts=%u,trx=%u) Requesting administrative state change %s -> %s [%s]\n",</span><br><span>             trx->bts->nr, trx->nr,</span><br><span>              get_value_string(abis_nm_adm_state_names, trx->mo.nm_state.administrative),</span><br><span>       get_value_string(abis_nm_adm_state_names, new_state), reason);</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/13519">change 13519</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/13519"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-bsc </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>
<div style="display:none"> Gerrit-Change-Id: I429d00d1393c221070e4c9e0997cbd14ae96103e </div>
<div style="display:none"> Gerrit-Change-Number: 13519 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Vadim Yanitskiy <axilirator@gmail.com> </div>