<p>Pau Espin Pedrol <strong>merged</strong> this change.</p><p><a href="https://gerrit.osmocom.org/13525">View Change</a></p><div style="white-space:pre-wrap">Approvals:
  Jenkins Builder: Verified
  Pau Espin Pedrol: Looks good to me, approved

</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">util: use launch_sync API instead of manual wait<br><br>The API is available so no need to manually craft all steps in there.<br><br>Change-Id: I4afedb185f6e864929155981e8a2ec2df90110c3<br>---<br>M src/osmo_gsm_tester/util.py<br>1 file changed, 3 insertions(+), 12 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/osmo_gsm_tester/util.py b/src/osmo_gsm_tester/util.py</span><br><span>index e9a1f30..21653be 100644</span><br><span>--- a/src/osmo_gsm_tester/util.py</span><br><span>+++ b/src/osmo_gsm_tester/util.py</span><br><span>@@ -52,10 +52,7 @@</span><br><span>     '''</span><br><span>     from .process import Process</span><br><span>     proc = Process('patchelf', run_dir, ['patchelf', '--set-rpath', paths, binary])</span><br><span style="color: hsl(0, 100%, 40%);">-    proc.launch()</span><br><span style="color: hsl(0, 100%, 40%);">-    proc.wait()</span><br><span style="color: hsl(0, 100%, 40%);">-    if proc.result != 0:</span><br><span style="color: hsl(0, 100%, 40%);">-        raise RuntimeError('patchelf finished with err code %d' % proc.result)</span><br><span style="color: hsl(120, 100%, 40%);">+    proc.launch_sync()</span><br><span> </span><br><span> def ip_to_iface(ip):</span><br><span>     try:</span><br><span>@@ -91,10 +88,7 @@</span><br><span>     from .process import Process</span><br><span>     SETCAP_NET_RAW_BIN = 'osmo-gsm-tester_setcap_net_raw.sh'</span><br><span>     proc = Process(SETCAP_NET_RAW_BIN, run_dir, ['sudo', SETCAP_NET_RAW_BIN, binary])</span><br><span style="color: hsl(0, 100%, 40%);">-    proc.launch()</span><br><span style="color: hsl(0, 100%, 40%);">-    proc.wait()</span><br><span style="color: hsl(0, 100%, 40%);">-    if proc.result != 0:</span><br><span style="color: hsl(0, 100%, 40%);">-        raise RuntimeError('%s finished with err code %d' % (SETCAP_NET_RAW_BIN, proc.result))</span><br><span style="color: hsl(120, 100%, 40%);">+    proc.launch_sync()</span><br><span> </span><br><span> def setcap_net_admin(binary, run_dir):</span><br><span>     '''</span><br><span>@@ -104,10 +98,7 @@</span><br><span>     from .process import Process</span><br><span>     SETCAP_NET_ADMIN_BIN = 'osmo-gsm-tester_setcap_net_admin.sh'</span><br><span>     proc = Process(SETCAP_NET_ADMIN_BIN, run_dir, ['sudo', SETCAP_NET_ADMIN_BIN, binary])</span><br><span style="color: hsl(0, 100%, 40%);">-    proc.launch()</span><br><span style="color: hsl(0, 100%, 40%);">-    proc.wait()</span><br><span style="color: hsl(0, 100%, 40%);">-    if proc.result != 0:</span><br><span style="color: hsl(0, 100%, 40%);">-        raise RuntimeError('%s finished with err code %d' % (SETCAP_NET_ADMIN_BIN, proc.result))</span><br><span style="color: hsl(120, 100%, 40%);">+    proc.launch_sync()</span><br><span> </span><br><span> def import_path_prepend(pathname):</span><br><span>     dir = os.path.realpath(pathname)</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/13525">change 13525</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/13525"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-gsm-tester </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: merged </div>
<div style="display:none"> Gerrit-Change-Id: I4afedb185f6e864929155981e8a2ec2df90110c3 </div>
<div style="display:none"> Gerrit-Change-Number: 13525 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Pau Espin Pedrol <pespin@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder (1000002) </div>
<div style="display:none"> Gerrit-Reviewer: Pau Espin Pedrol <pespin@sysmocom.de> </div>