<p>Pau Espin Pedrol has uploaded this change for <strong>review</strong>.</p><p><a href="https://gerrit.osmocom.org/13528">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">suite: Make _processes an empty list during init time<br><br>It simplifies the code because we don't need to check if it is a list or<br>not.<br><br>Change-Id: I634901a1f4ba3a6b7294666012ea679ae148ff08<br>---<br>M src/osmo_gsm_tester/suite.py<br>1 file changed, 10 insertions(+), 13 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://gerrit.osmocom.org:29418/osmo-gsm-tester refs/changes/28/13528/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/osmo_gsm_tester/suite.py b/src/osmo_gsm_tester/suite.py</span><br><span>index aefdc24..85eca46 100644</span><br><span>--- a/src/osmo_gsm_tester/suite.py</span><br><span>+++ b/src/osmo_gsm_tester/suite.py</span><br><span>@@ -73,7 +73,7 @@</span><br><span>         self._resource_requirements = None</span><br><span>         self._resource_modifiers = None</span><br><span>         self._config = None</span><br><span style="color: hsl(0, 100%, 40%);">-        self._processes = None</span><br><span style="color: hsl(120, 100%, 40%);">+        self._processes = []</span><br><span>         self._run_dir = None</span><br><span>         self.trial = trial</span><br><span>         self.definition = suite_definition</span><br><span>@@ -241,8 +241,6 @@</span><br><span>         process managed by suite finishes before cleanup time, the current test</span><br><span>         will be marked as FAIL and end immediatelly. If respwan=True, then suite</span><br><span>         will respawn() the process instead.'''</span><br><span style="color: hsl(0, 100%, 40%);">-        if self._processes is None:</span><br><span style="color: hsl(0, 100%, 40%);">-            self._processes = []</span><br><span>         self._processes.insert(0, (process, respawn))</span><br><span> </span><br><span>     def stop_processes(self):</span><br><span>@@ -396,16 +394,15 @@</span><br><span>         return bvci</span><br><span> </span><br><span>     def poll(self):</span><br><span style="color: hsl(0, 100%, 40%);">-        if self._processes:</span><br><span style="color: hsl(0, 100%, 40%);">-            for proc, respawn in self._processes:</span><br><span style="color: hsl(0, 100%, 40%);">-                if proc.terminated():</span><br><span style="color: hsl(0, 100%, 40%);">-                    if respawn == True:</span><br><span style="color: hsl(0, 100%, 40%);">-                        proc.respawn()</span><br><span style="color: hsl(0, 100%, 40%);">-                    else:</span><br><span style="color: hsl(0, 100%, 40%);">-                        proc.log_stdout_tail()</span><br><span style="color: hsl(0, 100%, 40%);">-                        proc.log_stderr_tail()</span><br><span style="color: hsl(0, 100%, 40%);">-                        log.ctx(proc)</span><br><span style="color: hsl(0, 100%, 40%);">-                        raise log.Error('Process ended prematurely: %s' % proc.name())</span><br><span style="color: hsl(120, 100%, 40%);">+        for proc, respawn in self._processes:</span><br><span style="color: hsl(120, 100%, 40%);">+            if proc.terminated():</span><br><span style="color: hsl(120, 100%, 40%);">+                if respawn == True:</span><br><span style="color: hsl(120, 100%, 40%);">+                    proc.respawn()</span><br><span style="color: hsl(120, 100%, 40%);">+                else:</span><br><span style="color: hsl(120, 100%, 40%);">+                    proc.log_stdout_tail()</span><br><span style="color: hsl(120, 100%, 40%);">+                    proc.log_stderr_tail()</span><br><span style="color: hsl(120, 100%, 40%);">+                    log.ctx(proc)</span><br><span style="color: hsl(120, 100%, 40%);">+                    raise log.Error('Process ended prematurely: %s' % proc.name())</span><br><span> </span><br><span>     def prompt(self, *msgs, **msg_details):</span><br><span>         'ask for user interaction. Do not use in tests that should run automatically!'</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/13528">change 13528</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/13528"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-gsm-tester </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>
<div style="display:none"> Gerrit-Change-Id: I634901a1f4ba3a6b7294666012ea679ae148ff08 </div>
<div style="display:none"> Gerrit-Change-Number: 13528 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Pau Espin Pedrol <pespin@sysmocom.de> </div>