<p>Pau Espin Pedrol has uploaded this change for <strong>review</strong>.</p><p><a href="https://gerrit.osmocom.org/13527">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">process: Early return during process termination if no proc running<br><br>This avoids extra unneeded logging about killing with signal when<br>actually no signal is being sent.<br><br>Change-Id: I5b5dd78fe3301d8eef2ab93da3b37029268ae198<br>---<br>M src/osmo_gsm_tester/process.py<br>1 file changed, 6 insertions(+), 1 deletion(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://gerrit.osmocom.org:29418/osmo-gsm-tester refs/changes/27/13527/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/osmo_gsm_tester/process.py b/src/osmo_gsm_tester/process.py</span><br><span>index 441d4ea..66ecae5 100644</span><br><span>--- a/src/osmo_gsm_tester/process.py</span><br><span>+++ b/src/osmo_gsm_tester/process.py</span><br><span>@@ -104,7 +104,10 @@</span><br><span>             time.sleep(wait_step)</span><br><span> </span><br><span>     def terminate_all(self):</span><br><span style="color: hsl(0, 100%, 40%);">-        self.dbg("Scheduled to terminate %d processes." % len(self._processes))</span><br><span style="color: hsl(120, 100%, 40%);">+        num_processes = len(self._processes)</span><br><span style="color: hsl(120, 100%, 40%);">+        self.dbg("Scheduled to terminate %d processes." % num_processes)</span><br><span style="color: hsl(120, 100%, 40%);">+        if num_processes == 0:</span><br><span style="color: hsl(120, 100%, 40%);">+            return</span><br><span>         self._prune_dead_processes(True)</span><br><span>         self._build_process_map()</span><br><span> </span><br><span>@@ -116,6 +119,8 @@</span><br><span>             if sig == signal.SIGKILL:</span><br><span>                 continue</span><br><span>             self._poll_for_termination()</span><br><span style="color: hsl(120, 100%, 40%);">+            if len(self._processes) == 0:</span><br><span style="color: hsl(120, 100%, 40%);">+                return</span><br><span> </span><br><span> </span><br><span> class Process(log.Origin):</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/13527">change 13527</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/13527"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-gsm-tester </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>
<div style="display:none"> Gerrit-Change-Id: I5b5dd78fe3301d8eef2ab93da3b37029268ae198 </div>
<div style="display:none"> Gerrit-Change-Number: 13527 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Pau Espin Pedrol <pespin@sysmocom.de> </div>