<p>Harald Welte <strong>merged</strong> this change.</p><p><a href="https://gerrit.osmocom.org/13351">View Change</a></p><div style="white-space:pre-wrap">Approvals:
  Jenkins Builder: Verified
  Harald Welte: Looks good to me, approved

</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">MSC_Tests: add testcase TC_sgsap_impl_imsi_det_noneps<br><br>We have a testcase that sends an explicit (UE-Initiated) imsi detach<br>from non EPS services. Lets also cover the case for an implicit<br>(Network-initated) detach.<br><br>Change-Id: I76049e6717680c54c18f97b7cd51944901a81ae7<br>Related: OS#3614<br>---<br>M msc/MSC_Tests.ttcn<br>M msc/expected-results.xml<br>2 files changed, 29 insertions(+), 0 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/msc/MSC_Tests.ttcn b/msc/MSC_Tests.ttcn</span><br><span>index a15fa57..ca633dc 100644</span><br><span>--- a/msc/MSC_Tests.ttcn</span><br><span>+++ b/msc/MSC_Tests.ttcn</span><br><span>@@ -3854,6 +3854,33 @@</span><br><span>        vc_conn.done;</span><br><span> }</span><br><span> </span><br><span style="color: hsl(120, 100%, 40%);">+private function f_tc_sgsap_impl_imsi_det_noneps(charstring id, BSC_ConnHdlrPars pars)</span><br><span style="color: hsl(120, 100%, 40%);">+runs on BSC_ConnHdlr {</span><br><span style="color: hsl(120, 100%, 40%);">+        f_init_handler(pars);</span><br><span style="color: hsl(120, 100%, 40%);">+ f_sgs_perform_lu();</span><br><span style="color: hsl(120, 100%, 40%);">+   f_sleep(3.0);</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+       var octetstring mme_name := f_enc_dns_hostname(mp_mme_name);</span><br><span style="color: hsl(120, 100%, 40%);">+  SGsAP.send(ts_SGsAP_IMSI_DETACH_IND(g_pars.imsi, mme_name, implicit_network_initiated));</span><br><span style="color: hsl(120, 100%, 40%);">+      SGsAP.receive(tr_SGsAP_IMSI_DETACH_ACK(g_pars.imsi));</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+       if (f_ctrl_subscr_in_vlr(hex2str(g_pars.imsi))) {</span><br><span style="color: hsl(120, 100%, 40%);">+             setverdict(fail, "subscriber not removed from VLR");</span><br><span style="color: hsl(120, 100%, 40%);">+        }</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+   f_sgsap_bssmap_screening();</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ setverdict(pass);</span><br><span style="color: hsl(120, 100%, 40%);">+}</span><br><span style="color: hsl(120, 100%, 40%);">+testcase TC_sgsap_impl_imsi_det_noneps() runs on MTC_CT {</span><br><span style="color: hsl(120, 100%, 40%);">+       var BSC_ConnHdlrPars pars;</span><br><span style="color: hsl(120, 100%, 40%);">+    var BSC_ConnHdlr vc_conn;</span><br><span style="color: hsl(120, 100%, 40%);">+     f_init(1, true);</span><br><span style="color: hsl(120, 100%, 40%);">+      pars := f_init_pars(11815, true);</span><br><span style="color: hsl(120, 100%, 40%);">+     vc_conn := f_start_handler_with_pars(refers(f_tc_sgsap_impl_imsi_det_noneps), pars);</span><br><span style="color: hsl(120, 100%, 40%);">+  vc_conn.done;</span><br><span style="color: hsl(120, 100%, 40%);">+}</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span> /* Trigger a paging request via VTY and send a paging reject in response */</span><br><span> private function f_tc_sgsap_paging_rej(charstring id, BSC_ConnHdlrPars pars)</span><br><span> runs on BSC_ConnHdlr {</span><br><span>@@ -4649,6 +4676,7 @@</span><br><span>  execute( TC_sgsap_lu_and_nothing() );</span><br><span>        execute( TC_sgsap_expl_imsi_det_eps() );</span><br><span>     execute( TC_sgsap_expl_imsi_det_noneps() );</span><br><span style="color: hsl(120, 100%, 40%);">+   execute( TC_sgsap_impl_imsi_det_noneps() );</span><br><span>  execute( TC_sgsap_paging_rej() );</span><br><span>    execute( TC_sgsap_paging_subscr_rej() );</span><br><span>     execute( TC_sgsap_paging_ue_unr() );</span><br><span>diff --git a/msc/expected-results.xml b/msc/expected-results.xml</span><br><span>index 86e8a89..e829493 100644</span><br><span>--- a/msc/expected-results.xml</span><br><span>+++ b/msc/expected-results.xml</span><br><span>@@ -75,6 +75,7 @@</span><br><span>   <testcase classname='MSC_Tests' name='TC_sgsap_lu_and_nothing' time='MASKED'/></span><br><span>   <testcase classname='MSC_Tests' name='TC_sgsap_expl_imsi_det_eps' time='MASKED'/></span><br><span>   <testcase classname='MSC_Tests' name='TC_sgsap_expl_imsi_det_noneps' time='MASKED'/></span><br><span style="color: hsl(120, 100%, 40%);">+  <testcase classname='MSC_Tests' name='TC_sgsap_impl_imsi_det_noneps' time='MASKED'/></span><br><span>   <testcase classname='MSC_Tests' name='TC_sgsap_paging_rej' time='MASKED'/></span><br><span>   <testcase classname='MSC_Tests' name='TC_sgsap_paging_subscr_rej' time='MASKED'/></span><br><span>   <testcase classname='MSC_Tests' name='TC_sgsap_paging_ue_unr' time='MASKED'/></span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/13351">change 13351</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/13351"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-ttcn3-hacks </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: merged </div>
<div style="display:none"> Gerrit-Change-Id: I76049e6717680c54c18f97b7cd51944901a81ae7 </div>
<div style="display:none"> Gerrit-Change-Number: 13351 </div>
<div style="display:none"> Gerrit-PatchSet: 3 </div>
<div style="display:none"> Gerrit-Owner: dexter <pmaier@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: Harald Welte <laforge@gnumonks.org> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder (1000002) </div>