<p>dexter has uploaded this change for <strong>review</strong>.</p><p><a href="https://gerrit.osmocom.org/13475">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">fixup<br><br>Change-Id: Iecec05aeaca4ab4578a5a240802c01a24cd52597<br>---<br>M pySim/cards.py<br>1 file changed, 8 insertions(+), 1 deletion(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://gerrit.osmocom.org:29418/pysim refs/changes/75/13475/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/pySim/cards.py b/pySim/cards.py</span><br><span>index 6a26dc7..fb84a8d 100644</span><br><span>--- a/pySim/cards.py</span><br><span>+++ b/pySim/cards.py</span><br><span>@@ -119,9 +119,16 @@</span><br><span>           return sw</span><br><span> </span><br><span>        def update_ad(self, mnc):</span><br><span style="color: hsl(120, 100%, 40%);">+                #See also: 3GPP TS 31.102, chapter 4.2.18</span><br><span style="color: hsl(120, 100%, 40%);">+                mnclen = len(str(mnc))</span><br><span style="color: hsl(120, 100%, 40%);">+                if mnclen == 1:</span><br><span style="color: hsl(120, 100%, 40%);">+                        mnclen = 2</span><br><span style="color: hsl(120, 100%, 40%);">+                if mnclen > 3:</span><br><span style="color: hsl(120, 100%, 40%);">+                  raise RuntimeError('unable to calculate proper mnclen')</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span>            data = self._scc.read_binary(EF['AD'], length=None, offset=0)</span><br><span>                 size = len(data[0])/2</span><br><span style="color: hsl(0, 100%, 40%);">-                content = data[0][0:6] + "%02X" % len(str(mnc))</span><br><span style="color: hsl(120, 100%, 40%);">+                content = data[0][0:6] + "%02X" % mnclen</span><br><span>          data, sw = self._scc.update_binary(EF['AD'], content)</span><br><span>                return sw</span><br><span> </span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/13475">change 13475</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/13475"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: pysim </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>
<div style="display:none"> Gerrit-Change-Id: Iecec05aeaca4ab4578a5a240802c01a24cd52597 </div>
<div style="display:none"> Gerrit-Change-Number: 13475 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: dexter <pmaier@sysmocom.de> </div>