<p>Harald Welte <strong>merged</strong> this change.</p><p><a href="https://gerrit.osmocom.org/13399">View Change</a></p><div style="white-space:pre-wrap">Approvals:
Jenkins Builder: Verified
Harald Welte: Looks good to me, but someone else must approve
Pau Espin Pedrol: Looks good to me, approved
</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">core/linuxlist.h: fix white-space and inconsistent alignment<br><br> - fix trailing white-space;<br> - properly align parameters of functions;<br> - use tabs instead of 8 spaces where possible.<br><br>Change-Id: Iaf616592a6bd72a1e7e94d8c55475710868beef0<br>---<br>M include/osmocom/core/linuxlist.h<br>1 file changed, 19 insertions(+), 19 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/include/osmocom/core/linuxlist.h b/include/osmocom/core/linuxlist.h</span><br><span>index d040d90..867605e 100644</span><br><span>--- a/include/osmocom/core/linuxlist.h</span><br><span>+++ b/include/osmocom/core/linuxlist.h</span><br><span>@@ -29,8 +29,8 @@</span><br><span> * \param[in] member the name of the member within the struct.</span><br><span> */</span><br><span> #define container_of(ptr, type, member) ({ \</span><br><span style="color: hsl(0, 100%, 40%);">- const typeof( ((type *)0)->member ) *__mptr = (ptr); \</span><br><span style="color: hsl(0, 100%, 40%);">- (type *)( (char *)__mptr - offsetof(type, member) );})</span><br><span style="color: hsl(120, 100%, 40%);">+ const typeof( ((type *)0)->member ) *__mptr = (ptr); \</span><br><span style="color: hsl(120, 100%, 40%);">+ (type *)( (char *)__mptr - offsetof(type, member) );})</span><br><span> </span><br><span> </span><br><span> /*!</span><br><span>@@ -72,8 +72,8 @@</span><br><span> * the prev/next entries already!</span><br><span> */</span><br><span> static inline void __llist_add(struct llist_head *_new,</span><br><span style="color: hsl(0, 100%, 40%);">- struct llist_head *prev,</span><br><span style="color: hsl(0, 100%, 40%);">- struct llist_head *next)</span><br><span style="color: hsl(120, 100%, 40%);">+ struct llist_head *prev,</span><br><span style="color: hsl(120, 100%, 40%);">+ struct llist_head *next)</span><br><span> {</span><br><span> next->prev = _new;</span><br><span> _new->next = next;</span><br><span>@@ -137,7 +137,7 @@</span><br><span> static inline void llist_del_init(struct llist_head *entry)</span><br><span> {</span><br><span> __llist_del(entry->prev, entry->next);</span><br><span style="color: hsl(0, 100%, 40%);">- INIT_LLIST_HEAD(entry); </span><br><span style="color: hsl(120, 100%, 40%);">+ INIT_LLIST_HEAD(entry);</span><br><span> }</span><br><span> </span><br><span> /*! Delete from one llist and add as another's head.</span><br><span>@@ -146,8 +146,8 @@</span><br><span> */</span><br><span> static inline void llist_move(struct llist_head *llist, struct llist_head *head)</span><br><span> {</span><br><span style="color: hsl(0, 100%, 40%);">- __llist_del(llist->prev, llist->next);</span><br><span style="color: hsl(0, 100%, 40%);">- llist_add(llist, head);</span><br><span style="color: hsl(120, 100%, 40%);">+ __llist_del(llist->prev, llist->next);</span><br><span style="color: hsl(120, 100%, 40%);">+ llist_add(llist, head);</span><br><span> }</span><br><span> </span><br><span> /*! Delete from one llist and add as another's tail.</span><br><span>@@ -155,10 +155,10 @@</span><br><span> * \param head the head that will follow our entry.</span><br><span> */</span><br><span> static inline void llist_move_tail(struct llist_head *llist,</span><br><span style="color: hsl(0, 100%, 40%);">- struct llist_head *head)</span><br><span style="color: hsl(120, 100%, 40%);">+ struct llist_head *head)</span><br><span> {</span><br><span style="color: hsl(0, 100%, 40%);">- __llist_del(llist->prev, llist->next);</span><br><span style="color: hsl(0, 100%, 40%);">- llist_add_tail(llist, head);</span><br><span style="color: hsl(120, 100%, 40%);">+ __llist_del(llist->prev, llist->next);</span><br><span style="color: hsl(120, 100%, 40%);">+ llist_add_tail(llist, head);</span><br><span> }</span><br><span> </span><br><span> /*! Test whether a linked list is empty.</span><br><span>@@ -171,7 +171,7 @@</span><br><span> }</span><br><span> </span><br><span> static inline void __llist_splice(struct llist_head *llist,</span><br><span style="color: hsl(0, 100%, 40%);">- struct llist_head *head)</span><br><span style="color: hsl(120, 100%, 40%);">+ struct llist_head *head)</span><br><span> {</span><br><span> struct llist_head *first = llist->next;</span><br><span> struct llist_head *last = llist->prev;</span><br><span>@@ -201,7 +201,7 @@</span><br><span> * The llist is reinitialised.</span><br><span> */</span><br><span> static inline void llist_splice_init(struct llist_head *llist,</span><br><span style="color: hsl(0, 100%, 40%);">- struct llist_head *head)</span><br><span style="color: hsl(120, 100%, 40%);">+ struct llist_head *head)</span><br><span> {</span><br><span> if (!llist_empty(llist)) {</span><br><span> __llist_splice(llist, head);</span><br><span>@@ -253,7 +253,7 @@</span><br><span> */</span><br><span> #define llist_for_each(pos, head) \</span><br><span> for (pos = (head)->next, prefetch(pos->next); pos != (head); \</span><br><span style="color: hsl(0, 100%, 40%);">- pos = pos->next, prefetch(pos->next))</span><br><span style="color: hsl(120, 100%, 40%);">+ pos = pos->next, prefetch(pos->next))</span><br><span> </span><br><span> /*! Iterate over a linked list (no prefetch).</span><br><span> * \param pos the llist_head to use as a loop counter.</span><br><span>@@ -273,7 +273,7 @@</span><br><span> */</span><br><span> #define llist_for_each_prev(pos, head) \</span><br><span> for (pos = (head)->prev, prefetch(pos->prev); pos != (head); \</span><br><span style="color: hsl(0, 100%, 40%);">- pos = pos->prev, prefetch(pos->prev))</span><br><span style="color: hsl(120, 100%, 40%);">+ pos = pos->prev, prefetch(pos->prev))</span><br><span> </span><br><span> /*! Iterate over a linked list, safe against removal of llist entry.</span><br><span> * \param pos the llist_head to use as a loop counter.</span><br><span>@@ -340,12 +340,12 @@</span><br><span> */</span><br><span> #define llist_for_each_rcu(pos, head) \</span><br><span> for (pos = (head)->next, prefetch(pos->next); pos != (head); \</span><br><span style="color: hsl(0, 100%, 40%);">- pos = pos->next, ({ smp_read_barrier_depends(); 0;}), prefetch(pos->next))</span><br><span style="color: hsl(0, 100%, 40%);">- </span><br><span style="color: hsl(120, 100%, 40%);">+ pos = pos->next, ({ smp_read_barrier_depends(); 0;}), prefetch(pos->next))</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span> #define __llist_for_each_rcu(pos, head) \</span><br><span> for (pos = (head)->next; pos != (head); \</span><br><span style="color: hsl(0, 100%, 40%);">- pos = pos->next, ({ smp_read_barrier_depends(); 0;}))</span><br><span style="color: hsl(0, 100%, 40%);">- </span><br><span style="color: hsl(120, 100%, 40%);">+ pos = pos->next, ({ smp_read_barrier_depends(); 0;}))</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span> /*! Iterate over an rcu-protected llist, safe against removal of llist entry.</span><br><span> * \param pos the llist_head to use as a loop counter.</span><br><span> * \param n another llist_head to use as temporary storage.</span><br><span>@@ -375,7 +375,7 @@</span><br><span> */</span><br><span> #define llist_for_each_continue_rcu(pos, head) \</span><br><span> for ((pos) = (pos)->next, prefetch((pos)->next); (pos) != (head); \</span><br><span style="color: hsl(0, 100%, 40%);">- (pos) = (pos)->next, ({ smp_read_barrier_depends(); 0;}), prefetch((pos)->next))</span><br><span style="color: hsl(120, 100%, 40%);">+ (pos) = (pos)->next, ({ smp_read_barrier_depends(); 0;}), prefetch((pos)->next))</span><br><span> </span><br><span> /*! Count number of llist items by iterating.</span><br><span> * \param head the llist head to count items of.</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/13399">change 13399</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/13399"/><meta itemprop="name" content="View Change"/></div></div>
<div style="display:none"> Gerrit-Project: libosmocore </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: merged </div>
<div style="display:none"> Gerrit-Change-Id: Iaf616592a6bd72a1e7e94d8c55475710868beef0 </div>
<div style="display:none"> Gerrit-Change-Number: 13399 </div>
<div style="display:none"> Gerrit-PatchSet: 4 </div>
<div style="display:none"> Gerrit-Owner: Vadim Yanitskiy <axilirator@gmail.com> </div>
<div style="display:none"> Gerrit-Reviewer: Harald Welte <laforge@gnumonks.org> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder (1000002) </div>
<div style="display:none"> Gerrit-Reviewer: Pau Espin Pedrol <pespin@sysmocom.de> </div>