<p>Neels Hofmeyr <strong>merged</strong> this change.</p><p><a href="https://gerrit.osmocom.org/13258">View Change</a></p><div style="white-space:pre-wrap">Approvals:
  Harald Welte: Looks good to me, approved
  Jenkins Builder: Verified

</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">avoid use-after-free: on MGW endpoint dealloc, also forget it in conn->ho.*<br><br>With the FORGET_MGW_ENDPOINT event, the MGW endpoint FSM notifies the gscon<br>that it has deallocated and that hence the gscon should forget all references<br>to it (to avoid a use-after-free).<br><br>Also do this for the endpoint FSM and endpoint ci pointers in the conn->ho.*<br>sub struct.<br><br>I saw a use-after-free after a Handover Failure message tears down the lchan<br>and MGW endpoint before triggering the handover_fsm.c cleanup code, which also<br>tries to clean up an endpoint CI if it was created for the failed Handover.<br><br>Change-Id: I6702ccd0df44bea5eb8b26d471d7903c24e6e30b<br>---<br>M src/osmo-bsc/bsc_subscr_conn_fsm.c<br>1 file changed, 6 insertions(+), 3 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/osmo-bsc/bsc_subscr_conn_fsm.c b/src/osmo-bsc/bsc_subscr_conn_fsm.c</span><br><span>index 13a5730..1cc0c78 100644</span><br><span>--- a/src/osmo-bsc/bsc_subscr_conn_fsm.c</span><br><span>+++ b/src/osmo-bsc/bsc_subscr_conn_fsm.c</span><br><span>@@ -699,6 +699,7 @@</span><br><span> {</span><br><span>   conn->user_plane.mgw_endpoint = NULL;</span><br><span>     conn->user_plane.mgw_endpoint_ci_msc = NULL;</span><br><span style="color: hsl(120, 100%, 40%);">+       conn->ho.created_ci_for_msc = NULL;</span><br><span>       lchan_forget_mgw_endpoint(conn->lchan);</span><br><span>   lchan_forget_mgw_endpoint(conn->assignment.new_lchan);</span><br><span>    lchan_forget_mgw_endpoint(conn->ho.new_lchan);</span><br><span>@@ -706,9 +707,11 @@</span><br><span> </span><br><span> void gscon_forget_mgw_endpoint_ci(struct gsm_subscriber_connection *conn, struct mgwep_ci *ci)</span><br><span> {</span><br><span style="color: hsl(0, 100%, 40%);">-     if (ci != conn->user_plane.mgw_endpoint_ci_msc)</span><br><span style="color: hsl(0, 100%, 40%);">-              return;</span><br><span style="color: hsl(0, 100%, 40%);">- conn->user_plane.mgw_endpoint_ci_msc = NULL;</span><br><span style="color: hsl(120, 100%, 40%);">+       if (conn->ho.created_ci_for_msc == ci)</span><br><span style="color: hsl(120, 100%, 40%);">+             conn->ho.created_ci_for_msc = NULL;</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+      if (conn->user_plane.mgw_endpoint_ci_msc == ci)</span><br><span style="color: hsl(120, 100%, 40%);">+            conn->user_plane.mgw_endpoint_ci_msc = NULL;</span><br><span> }</span><br><span> </span><br><span> static void gscon_fsm_allstate(struct osmo_fsm_inst *fi, uint32_t event, void *data)</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/13258">change 13258</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/13258"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-bsc </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: merged </div>
<div style="display:none"> Gerrit-Change-Id: I6702ccd0df44bea5eb8b26d471d7903c24e6e30b </div>
<div style="display:none"> Gerrit-Change-Number: 13258 </div>
<div style="display:none"> Gerrit-PatchSet: 2 </div>
<div style="display:none"> Gerrit-Owner: Neels Hofmeyr <nhofmeyr@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: Harald Welte <laforge@gnumonks.org> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder (1000002) </div>
<div style="display:none"> Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr@sysmocom.de> </div>