<p>Harald Welte <strong>merged</strong> this change.</p><p><a href="https://gerrit.osmocom.org/13385">View Change</a></p><div style="white-space:pre-wrap">Approvals:
  Jenkins Builder: Verified
  Harald Welte: Looks good to me, approved

Objections:
  Pau Espin Pedrol: I would prefer this is not merged as is

</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">Revert "signal.c: Make non-exported tall_sigh_ctx static"<br><br>This reverts commit cff2242e686be9ac19ba5757a710bc769a9201ec.<br><br>The patch broke openbsc:<br>../../src/libcommon/libcommon.a(talloc_ctx.o): In function `talloc_ctx_init':<br>/build/openbsc/src/libcommon/talloc_ctx.c:50: undefined reference to `tall_sigh_ctx'<br><br>See also:<br>https://lists.osmocom.org/pipermail/openbsc/2019-March/012843.html<br><br>Change-Id: Ib4cb31427a1cad063bc9f1a10b9c3182b314a9f2<br>---<br>M src/signal.c<br>1 file changed, 1 insertion(+), 1 deletion(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/signal.c b/src/signal.c</span><br><span>index f988419..be3b777 100644</span><br><span>--- a/src/signal.c</span><br><span>+++ b/src/signal.c</span><br><span>@@ -36,7 +36,7 @@</span><br><span>  * \file signal.c */</span><br><span> </span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-static void *tall_sigh_ctx;</span><br><span style="color: hsl(120, 100%, 40%);">+void *tall_sigh_ctx;</span><br><span> static LLIST_HEAD(signal_handler_list);</span><br><span> </span><br><span> struct signal_handler {</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/13385">change 13385</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/13385"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: libosmocore </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: merged </div>
<div style="display:none"> Gerrit-Change-Id: Ib4cb31427a1cad063bc9f1a10b9c3182b314a9f2 </div>
<div style="display:none"> Gerrit-Change-Number: 13385 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: osmith <osmith@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: Harald Welte <laforge@gnumonks.org> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder (1000002) </div>
<div style="display:none"> Gerrit-Reviewer: Max <msuraev@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: Pau Espin Pedrol <pespin@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: Vadim Yanitskiy <axilirator@gmail.com> </div>
<div style="display:none"> Gerrit-Reviewer: osmith <osmith@sysmocom.de> </div>